Merged
Conversation
awaterma
requested changes
Apr 27, 2020
Member
awaterma
left a comment
awaterma
left a comment
There was a problem hiding this comment.
I had a few suggestions for the wording and shortening the function slightly.
Member
|
I'm also wondering if we should look at other methods that could benefit from this parsing. |
ShivanKaul
reviewed
Jul 20, 2020
Contributor
|
@awaterma did you have any other comments on this PR? It looks good to merge to me. |
awaterma
approved these changes
Jul 23, 2020
Member
awaterma
left a comment
awaterma
left a comment
There was a problem hiding this comment.
I think this is good; we can revisit pulling this in as a dependency if we end up adding more or require different validations in the future. Thank you @medelibero-sfdc!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for #145