Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix chocolatey install/ uninstall for vs2017 #2233
Conversation
|
Related to chocolatey/choco#1201 |
DHowett-MSFT left a comment
|
We should depend on vswhere as a chocolatey package instead of shipping an ever-unchanging binary. Also, what happened with ThirdPartyNotices? It looks like it went through an industrial-scale shredder. |
bbowman
force-pushed the
bbowman:bbowman/fix_tools_install
branch
from
7c67179
to
e049bbc
| <PackageReleaseNotes> | ||
| </PackageReleaseNotes> | ||
| <PackageProjectUrl>https://github.com/Microsoft/WinObjC</PackageProjectUrl> | ||
| <PackageLicenseUrl> | ||
| </PackageLicenseUrl> | ||
| <PackageLicenseUrl>https://github.com/Microsoft/WinObjC/blob/develop/license.txt</PackageLicenseUrl> |
This comment has been minimized.
This comment has been minimized.
memontic-ms
Mar 14, 2017
Member
develop [](start = 65, length = 7)
This develop's license, not master's. IMO probably want to have the license that our releases will be associated with. They are currently the same though.
This comment has been minimized.
This comment has been minimized.
bbowman
Mar 14, 2017
Author
Member
I was thinking develop since it will be the latest always. In case we have changes, this will most quickly reflect any license changes but I honestly don't know which is better.
In reply to: 106000391 [](ancestors = 106000391)
This comment has been minimized.
This comment has been minimized.
| <Summary>WinObjC.Tools</Summary> | ||
| <Description>WinObjC.Tools</Description> | ||
| <Summary>Command Line tools and Visual Studio Extensions for the WinObjC Project.</Summary> | ||
| <Description>Command Line tools and Visual Studio Extensions for the WinObjC Project. This package includes vsimporter, the tool to convert an existing xcode objective c project to a visual studio solution, as well as the Visual Studio Extensions for Objective C syntax highlighting and Nuget package creation. See https://github.com/Microsoft/WinObjC for more details.</Description> | ||
| <PackageReleaseNotes> | ||
| </PackageReleaseNotes> |
This comment has been minimized.
This comment has been minimized.
memontic-ms
Mar 14, 2017
Member
We should note here somewhere that this package is for VS 2017. Maybe compatibility notes specifically go in the PackageReleaseNotes section? At the very least change occurrences of Visual Studio to Visual Studio 2017 in the summary & description.
This comment has been minimized.
This comment has been minimized.
bbowman
Mar 14, 2017
Author
Member
its 2017 or later so I didn't want to be too specific. I'll add a line to description though.
| <Summary>WinObjC.Tools</Summary> | ||
| <Description>WinObjC.Tools</Description> | ||
| <Summary>Command Line tools and Visual Studio Extensions for the WinObjC Project.</Summary> | ||
| <Description>Command Line tools and Visual Studio Extensions for the WinObjC Project. This package includes vsimporter, the tool to convert an existing xcode objective c project to a visual studio solution, as well as the Visual Studio Extensions for Objective C syntax highlighting and Nuget package creation. See https://github.com/Microsoft/WinObjC for more details.</Description> |
This comment has been minimized.
This comment has been minimized.
memontic-ms
Mar 14, 2017
Member
visual studio [](start = 187, length = 13)
nit: Capitalize Visual Studio
| # despite the name "Install-ChocolateyZipPackage" this also works with 7z archives | ||
| #Install-ChocolateyZipPackage "$packageName" "$url" "$installDir" "$url64" | ||
| # END PORTABLE EXAMPLE | ||
| if($result -gt 0 -and $result -ne 1001) { #1001: Already installed |
This comment has been minimized.
This comment has been minimized.
memontic-ms
Mar 14, 2017
Member
#1001: Already installed [](start = 42, length = 24)
Wouldn't hurt to Write-Host the already installed case.
Also, is there any indication that an install was successful besides it not failing? Is there Chocolatey magic that does that?
This comment has been minimized.
This comment has been minimized.
bbowman
Mar 14, 2017
Author
Member
Following the Install-ChocoalteyVsix pattern as much as possible here which doesn't. #wontfix
ditta95aR left a comment
|
|
|
@DHowett-MSFT updated. |
bbowman commentedMar 14, 2017
No description provided.