The Wayback Machine - https://web.archive.org/web/20201206230415/https://github.com/Autodesk/hubble/pull/4
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to MIT license #4

Merged
merged 1 commit into from Oct 13, 2017
Merged

Switch to MIT license #4

merged 1 commit into from Oct 13, 2017

Conversation

@pluehne
Copy link
Member

@pluehne pluehne commented Oct 9, 2017

I propose switching Hubble to the MIT license.

The reasons are mainly that the MIT license is more concise and permissive than the current Apache 2.0 license. Furthermore, there is only little benefit for us in forcing forks of this project to list all of their modifications—most of them will do that anyway.

By the way, I would suggest removing the License section from the readme. There is a separate file for that, and GitHub already shows the used license prominently in the header bar 😃.

@pluehne pluehne requested a review from larsxschneider Oct 9, 2017
@pluehne pluehne force-pushed the patrick/license branch from 1c6a371 to 1d62b9a Oct 9, 2017
@pluehne pluehne force-pushed the patrick/license branch from 1d62b9a to 804927a Oct 9, 2017
@pluehne pluehne added the suggestion label Oct 10, 2017
@pluehne pluehne self-assigned this Oct 10, 2017
@pluehne pluehne added this to Under Review in Hubble Enterprise 0.1.1 Oct 10, 2017
@larsxschneider larsxschneider merged commit 274be62 into master Oct 13, 2017
@larsxschneider larsxschneider deleted the patrick/license branch Oct 13, 2017
@larsxschneider
Copy link
Collaborator

@larsxschneider larsxschneider commented Oct 13, 2017

@craigez
Copy link
Contributor

@craigez craigez commented Oct 13, 2017

👍 Thanks!

Personally, I would have left a license reference in the README file.

@larsxschneider
Copy link
Collaborator

@larsxschneider larsxschneider commented Oct 13, 2017

Personally, I would have left a license reference in the README file.

Just a gut feeling or do you have some argument/best practice we could/should follow here?

@pluehne pluehne moved this from Under Review to Done in Hubble Enterprise 0.1.1 Oct 13, 2017
@craigez
Copy link
Contributor

@craigez craigez commented Oct 13, 2017

It's a little bit of both. I have a gut feeling that the more mention of licenses the better! Additionally, one of the default rulesets we've set up for this TODO group repo linter is to check the license file is referenced in the README: https://github.com/todogroup/repolinter/blob/master/rulesets/default.json#L8

I would also encourage adding it with the "SPDX-License-Identifier" keyword, i.e. "SPDX-License-Identifier: MIT".

@craigez
Copy link
Contributor

@craigez craigez commented Oct 13, 2017

See #12

@craigez
Copy link
Contributor

@craigez craigez commented Oct 13, 2017

@pluehne
Copy link
Member Author

@pluehne pluehne commented Oct 13, 2017

@craigez: No worries, feel free to rebase the branch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.