Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fixes #58: Adds a JS testing framework and other JS goodies #61
Conversation
|
Looks all good to me. Please take a look at my linter question... then I can merge |
|
|
||
| ### Linting | ||
|
|
||
| $ npm run lint |
larsxschneider
Dec 14, 2017
Collaborator
The linter complains it can't find a config file. I guess this is expected?
The linter complains it can't find a config file. I guess this is expected?
filmaj
Dec 14, 2017
Author
Contributor
Ah yes, I have it ready to go but I was going to wait until the tests were merged before adding all the various bits. I will remove these instructions for now until I put together the full additions for linting. I'll also rebase with latest master.
Ah yes, I have it ready to go but I was going to wait until the tests were merged before adding all the various bits. I will remove these instructions for now until I put together the full additions for linting. I'll also rebase with latest master.
|
Plus, don't worry about the conflict. I can fix it while merging. |
…nto the project, allowing us to include running them in the test runner
…ners and dependencies. Basic smoke tests for charts.js. Karma test runner configuration for running in headless chrome.
|
I've rebased and removed the linter instructions. Once this is merged, I've got all the parts for the linter ready to go - but I'll issue a separate PR for that. |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

I needed to make a few big changes to add JS testing. Additionally, this PR includes many tweaks to the documentation - so feedback is much appreciated😄
Summary of Changes
charts.jssource file we author directly depends on them and assumes they are available globally.CONTRIBUTING.mddocumentation to explain where to look for info on how to validate (i.e. run the tests) the web app component.README.mdto explain what the updater and docs subdirectory / components are and linking to their relevant READMEs.README.mdto thedocs/component, explaining (in so far as I understand) how the web app works, how it is structured, and how to run tests (and in the hopefully-near-future, linter)._config.ymlto exclude the extra node.js bits, like dependency directory and config files.charts.js- nothing more than checking for the existence of our maincreateChartfunctions. Hopefully, with every bug we identify therein, or with every new JS feature we add, we can also add tests now.Try It Out
Ensure you have Google Chrome installed (and updated). Ensure you have a recent version of node.js available. Pull this branch down, then:
Want to see what a failing test looks like? Edit
docs/spec/charts.js, and inside one of the test blocks (encapsulated via theit()function), addexpect(false).toBe(true);- then rerun the tests vianpm test. Oh no! Angry red text and error stack traces everywhere!