Ensure content filter runs after wp_filter_content_tags#1236
Ensure content filter runs after wp_filter_content_tags#1236adamsilverstein wants to merge 2 commits intoWordPress:trunkfrom
wp_filter_content_tags#1236Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I tested this fix with the image from the issue and also verified the fallback script still works correctly. |
joemcgill
left a comment
There was a problem hiding this comment.
This will work, but I'd suggest using the wp_calculate_image_srcset filter for this instead so you don't have to rerun a preg_match on the final content. Approving for now since this addresses the issue.
Great suggestion, I will open an issue to follow up with this improvement. |
|
Otherwise I was goin to suggest that |
I created a follow up Issue to consider this improvement. |
Summary
Ensures
srcsetis generated when JPEG generation is enabledFixes #1207
Relevant technical choices
Delay filtering
the_contentsosrcsetis properly generated when "Generate JPEG files in addition to WebP" is enabled.