Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[18.09 backport] BuildKit fixes for 18.09.1#122

Merged
andrewhsu merged 4 commits intodocker-archive:18.09from
tonistiigi:buildkit-18091
Nov 26, 2018
Merged

[18.09 backport] BuildKit fixes for 18.09.1#122
andrewhsu merged 4 commits intodocker-archive:18.09from
tonistiigi:buildkit-18091

Conversation

@tonistiigi
Copy link
Copy Markdown

@tonistiigi tonistiigi commented Nov 21, 2018 •
edited
Loading

Brings in following:

Possibly could also use "builder: add workaround for gcr auth issue" moby#38246 but needs upstream reviews first

@tiborvass @thaJeztah

Tibor Vass and others added 4 commits November 21, 2018 14:08
@tonistiigi
builder: deprecate prune filter unused-for in favor of until
0b2d88d 
This is to keep the UX consistent. `unused-for` is still accepted and a synonym.

Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit 369da26)
@tonistiigi
builder: ignore label and label! prune filters
3486764 
Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit 62923f2)
@tonistiigi
builder: avoid unset credentials in containerd
0d17f40 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
(cherry picked from commit effb2bd)
@tonistiigi
vendor: update buildkit to v0.3.3
850fff5 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
(cherry picked from commit 6204eb0)
@andrewhsu andrewhsu added this to the 18.09.1 milestone Nov 26, 2018
@andrewhsu
Copy link
Copy Markdown

andrewhsu commented Nov 26, 2018

Upstream changes in buildkit: moby/buildkit@c7bb575...8cf9bec
Upstream changes in fsutil: tonistiigi/fsutil@f567071...2862f6b

thaJeztah
thaJeztah approved these changes Nov 26, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrewhsu
andrewhsu approved these changes Nov 26, 2018
View reviewed changes
Copy link
Copy Markdown

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 9606931 into docker-archive:18.09 Nov 26, 2018
@thaJeztah thaJeztah mentioned this pull request Nov 27, 2018
Closed
@tonistiigi tonistiigi mentioned this pull request Nov 30, 2018
Merged
@haizaar haizaar mentioned this pull request Dec 7, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@andrewhsu andrewhsu andrewhsu approved these changes

@tiborvass tiborvass tiborvass approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.09.1

Development

Successfully merging this pull request may close these issues.

4 participants

@tonistiigi @andrewhsu @tiborvass @thaJeztah