Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: moby/swarmkit
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c66ed60822d3fc3bf6e17a505ee79014f449ef05
Choose a base ref
...
head repository: moby/swarmkit
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 19e791fd6dc76e8e894cbc99b77f946b7d00ebb9
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Mar 26, 2019

  1. Fix leaking task resources when nodes are deleted 

    When a node is deleted, its tasks are asked to restart, which involves
putting them into a desired state of Shutdown. However, the Allocator
will not deallocate a task which is not in an actual state of a terminal
state. Once a node is deleted, the only opportunity for its tasks to
recieve updates and be moved to a terminal state is when the function
moving those tasks to TaskStateOrphaned is called, 24 hours after the
node enters the Down state. However, if a leadership change occurs, then
that function will never be called, and the tasks will never be moved to
a terminal state, leaking resources.

With this change, upon node deletion, all of its tasks will be moved to
TaskStateOrphaned, allowing those tasks' resources to be cleaned up.

Signed-off-by: Drew Erny <drew.erny@docker.com>
(cherry picked from commit 8467e6a)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @dperny @thaJeztah
    dperny authored and thaJeztah committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    5d6f7be View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2019

  1. Merge pull request #2842 from thaJeztah/18.09_backport_fix_leaking_ta… 

    …sk_resources

[18.09 backport] Fix leaking task resources when nodes are deleted
    @dperny
    dperny authored Mar 28, 2019
    Configuration menu
    Copy the full SHA
    19e791f View commit details
    Browse the repository at this point in the history
Loading