cli/command: PromptUserForCredentials: always trim password

thaJeztah · thaJeztah · commit a21a5f424332 · 2024-10-19T12:10:46.000+02:00
we don't support empty passwords; when prompting the user for a password,
we already trim the result, but we didn't do the same for a password that's
passed through stdin or through the `-p` / `--password` flag.

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/cli/command/registry.go b/cli/command/registry.go
@@ -155,6 +155,7 @@ func PromptUserForCredentials(ctx context.Context, cli Cli, argUser, argPassword
 		}
 	}
 
+	argPassword = strings.TrimSpace(argPassword)
 	if argPassword == "" {
 		restoreInput, err := DisableInputEcho(cli.In())
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -155,6 +155,7 @@ func PromptUserForCredentials(ctx context.Context, cli Cli, argUser, argPassword`
`155`	`155`	`}`
`156`	`156`	`}`
`157`	`157`
	`158`	`+ argPassword = strings.TrimSpace(argPassword)`
`158`	`159`	`if argPassword == "" {`
`159`	`160`	`restoreInput, err := DisableInputEcho(cli.In())`
`160`	`161`	`if err != nil {`