Repository navigation
Add completion-aware realtime attachment and session-scoped detach - #51539
Merged
copyberry[bot] merged 1 commit intoOct 7, 2026
Conversation
…51539) ## Why A delayed detach or cleanup from an older realtime conversation must not close its replacement or end the replacement's history segment. Realtime start parameters can also contain credentials in text and transport endpoints, so diagnostics should avoid exposing them. ## What changed - Add `RealtimeConversationAttach` to report the connection attempt's result through a reply channel, using the sequential start path. - Add `RealtimeConversationDetach` to close only the matching `realtime_session_id` after earlier starts finish. Detaching an older session leaves the replacement connected. - Emit the previous conversation's close event before starting its replacement, and prevent stale fanout cleanup from closing or clearing the replacement's context. - Limit `ConversationStartParams` debug output to output modality, initial item count, and protocol version. ## Testing Add coverage for attachment completion after the handshake, stale detaches, failed replacement and retry, natural-close ordering, handoff history after replacement, and debug redaction for existing-call and WebRTC transports. GitOrigin-RevId: 23aee6f70522f0b17e6aa9349dbbcc2ea985f233
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/23aee6f70522f0b17e6aa9349dbbcc2ea985f233
branch
from
October 7, 2026 01:29
a87b40e to
4aaee87
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/23aee6f70522f0b17e6aa9349dbbcc2ea985f233
branch
October 7, 2026 01:29
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add completion-aware realtime attachment and session-scoped detach
Why
A delayed detach or cleanup from an older realtime conversation must not close its replacement or end the replacement's history segment. Realtime start parameters can also contain credentials in text and transport endpoints, so diagnostics should avoid exposing them.
What changed
RealtimeConversationAttachto report the connection attempt's result through a reply channel, using the sequential start path.RealtimeConversationDetachto close only the matchingrealtime_session_idafter earlier starts finish. Detaching an older session leaves the replacement connected.ConversationStartParamsdebug output to output modality, initial item count, and protocol version.Testing
Add coverage for attachment completion after the handshake, stale detaches, failed replacement and retry, natural-close ordering, handoff history after replacement, and debug redaction for existing-call and WebRTC transports.