Repository navigation
Add a Windows MXC sandbox opt-out - #51547
Merged
copyberry[bot] merged 1 commit intoOct 7, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## What changed Add `windows.allow_mxc` to configuration and its JSON schema. Setting it to `false` blocks automatic MXC selection even when `features.prefer_mxc` is enabled, and rejects explicit `windows.sandbox = "mxc"` configuration with a clear error. Omitting the setting preserves existing behavior. ## Testing Extend configuration tests to cover disabling automatic MXC selection and rejecting explicit MXC configuration when `windows.allow_mxc = false`. GitOrigin-RevId: bf7c0648cfcb3cc1d0dc41b9faffcb8078672780
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/bf7c0648cfcb3cc1d0dc41b9faffcb8078672780
branch
from
October 7, 2026 01:52
efbb5ad to
e95abcd
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/bf7c0648cfcb3cc1d0dc41b9faffcb8078672780
branch
October 7, 2026 01:52
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Windows MXC sandbox opt-out
What changed
Add
windows.allow_mxcto configuration and its JSON schema. Setting it tofalseblocks automatic MXC selection even whenfeatures.prefer_mxcis enabled, and rejects explicitwindows.sandbox = "mxc"configuration with a clear error. Omitting the setting preserves existing behavior.Testing
Extend configuration tests to cover disabling automatic MXC selection and rejecting explicit MXC configuration when
windows.allow_mxc = false.