Skip to content

Fix retained context handling for typed section content - #51642

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/e2205eaf9b31a2b8291dc6c0c22a899596b10206
Oct 7, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/e2205eaf9b31a2b8291dc6c0c22a899596b10206

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Fix retained context handling for typed section content

What changed

Update retained instruction splitting and empty assistant-context detection to match SectionContent::Other, and convert assistant framing markers into SectionContent.

Testing

Extend the snapshot-splitting regression test to use prepare_transcript with both line and JSON formats, with and without source message IDs. It checks evidence preservation, deduplication, and a stable instruction prefix as assistant context and reviews change.

## What changed

Update retained instruction splitting and empty assistant-context detection to match `SectionContent::Other`, and convert assistant framing markers into `SectionContent`.

## Testing

Extend the snapshot-splitting regression test to use `prepare_transcript` with both line and JSON formats, with and without source message IDs. It checks evidence preservation, deduplication, and a stable instruction prefix as assistant context and reviews change.

GitOrigin-RevId: e2205eaf9b31a2b8291dc6c0c22a899596b10206
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/e2205eaf9b31a2b8291dc6c0c22a899596b10206 branch from 209aeb8 to a513012 Compare October 7, 2026 10:33
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-07T10:33:46.800639Z 209aeb8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit a513012 into main Oct 7, 2026
9 of 14 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/e2205eaf9b31a2b8291dc6c0c22a899596b10206 branch October 7, 2026 10:33
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 7, 2026
@itsstevenliu
itsstevenliu deployed to issue-triage October 7, 2026 10:34 — with Image GitHub Actions Active
@itsstevenliu
itsstevenliu deployed to issue-triage October 7, 2026 10:34 — with Image GitHub Actions Active
@itsstevenliu
itsstevenliu deployed to issue-triage October 7, 2026 10:34 — with Image GitHub Actions Active
@jayceebasa
jayceebasa deployed to issue-triage October 7, 2026 10:39 — with Image GitHub Actions Active
@jayceebasa
jayceebasa deployed to issue-triage October 7, 2026 10:39 — with Image GitHub Actions Active
@jayceebasa
jayceebasa deployed to issue-triage October 7, 2026 10:39 — with Image GitHub Actions Active
@sun-binwen
sun-binwen deployed to issue-triage October 7, 2026 10:42 — with Image GitHub Actions Active
@sun-binwen
sun-binwen deployed to issue-triage October 7, 2026 10:42 — with Image GitHub Actions Active
@sun-binwen
sun-binwen deployed to issue-triage October 7, 2026 10:42 — with Image GitHub Actions Active
@sun-binwen
sun-binwen deployed to issue-triage October 7, 2026 10:43 — with Image GitHub Actions Active
@eczajnik
eczajnik deployed to issue-triage October 7, 2026 10:46 — with Image GitHub Actions Active
@eczajnik
eczajnik deployed to issue-triage October 7, 2026 10:46 — with Image GitHub Actions Active
@eczajnik
eczajnik deployed to issue-triage October 7, 2026 10:46 — with Image GitHub Actions Active
@Atletico1999
Atletico1999 deployed to issue-triage October 7, 2026 11:04 — with Image GitHub Actions Active
@Atletico1999
Atletico1999 deployed to issue-triage October 7, 2026 11:04 — with Image GitHub Actions Active
@Atletico1999
Atletico1999 deployed to issue-triage October 7, 2026 11:04 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — a5130128 Deployed Oct 7, 2026 by Atletico1999 via Identify potential duplicates (all issues) #52580
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants