Skip to content

Roll back stale Guardian reviews before reusing reviewer history - #51683

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/0bff6cc551fee1f0905082eb97ccdecaa8628867
Oct 7, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/0bff6cc551fee1f0905082eb97ccdecaa8628867

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Roll back stale Guardian reviews before reusing reviewer history

Why

Authorization updates during a pending Guardian approval can invalidate its decision. Retries need the updated guidance without inheriting the invalidated review or losing earlier valid context.

What changed

  • Validate authorization while the reviewer is reserved, before publishing its history checkpoint.
  • Roll back stale attempts to the last committed review, preserving earlier valid reviews across repeated invalidations.
  • Pin the issuing action's repository instruction snapshot for reviewers and retries, avoiding fresh instruction discovery through disconnected executors.
  • Treat stale authorization as a request for a new review rather than a failed decision.

Testing

Add regression coverage for repeated approval invalidation, retention of earlier valid context, exclusion of stale decisions, and execution of the pending action exactly once. Extend the disconnected-executor test to verify that retries retain repository instructions and use updated authorization.

)

## Why

Authorization updates during a pending Guardian approval can invalidate its decision. Retries need the updated guidance without inheriting the invalidated review or losing earlier valid context.

## What changed

- Validate authorization while the reviewer is reserved, before publishing its history checkpoint.
- Roll back stale attempts to the last committed review, preserving earlier valid reviews across repeated invalidations.
- Pin the issuing action's repository instruction snapshot for reviewers and retries, avoiding fresh instruction discovery through disconnected executors.
- Treat stale authorization as a request for a new review rather than a failed decision.

## Testing

Add regression coverage for repeated approval invalidation, retention of earlier valid context, exclusion of stale decisions, and execution of the pending action exactly once. Extend the disconnected-executor test to verify that retries retain repository instructions and use updated authorization.

GitOrigin-RevId: 0bff6cc551fee1f0905082eb97ccdecaa8628867
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/0bff6cc551fee1f0905082eb97ccdecaa8628867 branch from 2c14426 to 3421c66 Compare October 7, 2026 13:05
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-07T13:05:18.567954Z 2c14426 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit 3421c66 into main Oct 7, 2026
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/0bff6cc551fee1f0905082eb97ccdecaa8628867 branch October 7, 2026 13:05
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 7, 2026
@jdk32f2
jdk32f2 deployed to issue-triage October 7, 2026 13:13 — with Image GitHub Actions Active
@jdk32f2
jdk32f2 deployed to issue-triage October 7, 2026 13:13 — with Image GitHub Actions Active
@jdk32f2
jdk32f2 deployed to issue-triage October 7, 2026 13:13 — with Image GitHub Actions Active
@jaydenmilne
jaydenmilne deployed to issue-triage October 7, 2026 13:14 — with Image GitHub Actions Active
@jaydenmilne
jaydenmilne deployed to issue-triage October 7, 2026 13:14 — with Image GitHub Actions Active
@jaydenmilne
jaydenmilne deployed to issue-triage October 7, 2026 13:14 — with Image GitHub Actions Active
@IanRickard
IanRickard deployed to issue-triage October 7, 2026 13:15 — with Image GitHub Actions Active
@IanRickard
IanRickard deployed to issue-triage October 7, 2026 13:15 — with Image GitHub Actions Active
@IanRickard
IanRickard deployed to issue-triage October 7, 2026 13:15 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 3421c660 Deployed Oct 7, 2026 by IanRickard via Generate label suggestions #52628
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants