Skip to content

Honor tool-description-first ordering in Code Mode - #51704

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/1e3f84d2d95c200aef21ad710d367274b2169b4b
Oct 7, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/1e3f84d2d95c200aef21ad710d367274b2169b4b

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Honor tool-description-first ordering in Code Mode

What changed

Apply code_mode_tool_description_first when preparing nested tool definitions for Code Mode execution and tool search. When enabled, place each tool's description before its namespace description; otherwise, preserve namespace-first ordering.

Reuse cached MCP definitions only when both the input schema budget and description-order setting match.

Testing

Extend deferred app tool integration tests to cover both description orders with and without ranked search, including consistency between search results and ALL_TOOLS. Extend the MCP cache test to reject reuse when the description-order setting changes.

## What changed

Apply `code_mode_tool_description_first` when preparing nested tool definitions for Code Mode execution and tool search. When enabled, place each tool's description before its namespace description; otherwise, preserve namespace-first ordering.

Reuse cached MCP definitions only when both the input schema budget and description-order setting match.

## Testing

Extend deferred app tool integration tests to cover both description orders with and without ranked search, including consistency between search results and `ALL_TOOLS`. Extend the MCP cache test to reject reuse when the description-order setting changes.

GitOrigin-RevId: 1e3f84d2d95c200aef21ad710d367274b2169b4b
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/1e3f84d2d95c200aef21ad710d367274b2169b4b branch from 91035e2 to 0a2a64e Compare October 7, 2026 14:32
@copyberry
copyberry Bot merged commit 0a2a64e into main Oct 7, 2026
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/1e3f84d2d95c200aef21ad710d367274b2169b4b branch October 7, 2026 14:33
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-07T14:33:00.006398Z 91035e2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 7, 2026
@mdegraaf-del
mdegraaf-del deployed to issue-triage October 7, 2026 14:35 — with Image GitHub Actions Active
@mdegraaf-del
mdegraaf-del deployed to issue-triage October 7, 2026 14:35 — with Image GitHub Actions Active
@mdegraaf-del
mdegraaf-del deployed to issue-triage October 7, 2026 14:35 — with Image GitHub Actions Active
@tobisamaa
tobisamaa deployed to issue-triage October 7, 2026 14:36 — with Image GitHub Actions Active
@tobisamaa
tobisamaa deployed to issue-triage October 7, 2026 14:36 — with Image GitHub Actions Active
@tobisamaa
tobisamaa deployed to issue-triage October 7, 2026 14:36 — with Image GitHub Actions Active
@leiting684
leiting684 deployed to issue-triage October 7, 2026 14:38 — with Image GitHub Actions Active
@leiting684
leiting684 deployed to issue-triage October 7, 2026 14:38 — with Image GitHub Actions Active
@leiting684
leiting684 deployed to issue-triage October 7, 2026 14:38 — with Image GitHub Actions Active
@maution
maution deployed to issue-triage October 7, 2026 14:38 — with Image GitHub Actions Active
@maution
maution deployed to issue-triage October 7, 2026 14:38 — with Image GitHub Actions Active
@maution
maution deployed to issue-triage October 7, 2026 14:38 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 0a2a64e9 Deployed Oct 7, 2026 by maution via Generate label suggestions #52651
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants