Repository navigation
Honor tool-description-first ordering in Code Mode - #51704
Merged
copyberry[bot] merged 1 commit intoOct 7, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## What changed Apply `code_mode_tool_description_first` when preparing nested tool definitions for Code Mode execution and tool search. When enabled, place each tool's description before its namespace description; otherwise, preserve namespace-first ordering. Reuse cached MCP definitions only when both the input schema budget and description-order setting match. ## Testing Extend deferred app tool integration tests to cover both description orders with and without ranked search, including consistency between search results and `ALL_TOOLS`. Extend the MCP cache test to reject reuse when the description-order setting changes. GitOrigin-RevId: 1e3f84d2d95c200aef21ad710d367274b2169b4b
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/1e3f84d2d95c200aef21ad710d367274b2169b4b
branch
from
October 7, 2026 14:32
91035e2 to
0a2a64e
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/1e3f84d2d95c200aef21ad710d367274b2169b4b
branch
October 7, 2026 14:33
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honor tool-description-first ordering in Code Mode
What changed
Apply
code_mode_tool_description_firstwhen preparing nested tool definitions for Code Mode execution and tool search. When enabled, place each tool's description before its namespace description; otherwise, preserve namespace-first ordering.Reuse cached MCP definitions only when both the input schema budget and description-order setting match.
Testing
Extend deferred app tool integration tests to cover both description orders with and without ranked search, including consistency between search results and
ALL_TOOLS. Extend the MCP cache test to reject reuse when the description-order setting changes.