Repository navigation
Fix a discovery race in the external auth refresh test - #51710
Merged
copyberry[bot] merged 1 commit intoOct 7, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
Background discovery can cache a successful response before the test mounts its unauthorized-response mock, bypassing the intended token refresh. Mount the `401` mock before invalidating the route cached during login in `external_auth_refreshes_on_unauthorized`. GitOrigin-RevId: 8c280ca7287dab09230d534a44ca80d0835d2ef2
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/8c280ca7287dab09230d534a44ca80d0835d2ef2
branch
from
October 7, 2026 14:40
1cc0907 to
0e15206
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/8c280ca7287dab09230d534a44ca80d0835d2ef2
branch
October 7, 2026 14:41
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a discovery race in the external auth refresh test
Background discovery can cache a successful response before the test mounts
its unauthorized-response mock, bypassing the intended token refresh.
Mount the
401mock before invalidating the route cached during login inexternal_auth_refreshes_on_unauthorized.