Repository navigation
Load persisted sender context for Guardian reviews - #51734
Merged
copyberry[bot] merged 1 commit intoOct 7, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Guardian cannot capture sender instructions from another host when the sender thread is absent from the receiver's local runtime. ## What changed Fall back to the authenticated thread store to reconstruct sender history without resuming the sender. Respect compaction and rollback, and label persisted evidence to indicate that newer unpersisted messages may be missing. Limit storage reads to five seconds and capture sender context before acquiring the active-turn lock. Bind the captured evidence to the turn that accepts the delivery, allowing an existing turn to finish while the read is pending. ## Testing Add cross-host scenarios for legacy and paginated history that verify sender evidence reaches only Guardian and excludes rolled-back permissions. Add a gated storage-read test that verifies turn completion remains unblocked and evidence is bound to the newly accepted turn. GitOrigin-RevId: fe896f4e82fe3e32017fe4884846f3fa90a87949
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/fe896f4e82fe3e32017fe4884846f3fa90a87949
branch
from
October 7, 2026 15:47
3e8fa1e to
2dae757
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/fe896f4e82fe3e32017fe4884846f3fa90a87949
branch
October 7, 2026 15:47
derrickqi2003
had a problem deploying
to
issue-triage
October 7, 2026 16:10 — with
GitHub Actions
Failure
derrickqi2003
had a problem deploying
to
issue-triage
October 7, 2026 16:10 — with
GitHub Actions
Failure
derrickqi2003
had a problem deploying
to
issue-triage
October 7, 2026 16:10 — with
GitHub Actions
Failure
hfut2014211610
had a problem deploying
to
issue-triage
October 7, 2026 16:11 — with
GitHub Actions
Failure
hfut2014211610
had a problem deploying
to
issue-triage
October 7, 2026 16:11 — with
GitHub Actions
Failure
hfut2014211610
had a problem deploying
to
issue-triage
October 7, 2026 16:11 — with
GitHub Actions
Failure
drluisbarrios
had a problem deploying
to
issue-triage
October 7, 2026 16:13 — with
GitHub Actions
Failure
drluisbarrios
had a problem deploying
to
issue-triage
October 7, 2026 16:13 — with
GitHub Actions
Failure
drluisbarrios
had a problem deploying
to
issue-triage
October 7, 2026 16:13 — with
GitHub Actions
Failure
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load persisted sender context for Guardian reviews
Why
Guardian cannot capture sender instructions from another host when the sender thread is absent from the receiver's local runtime.
What changed
Fall back to the authenticated thread store to reconstruct sender history without resuming the sender. Respect compaction and rollback, and label persisted evidence to indicate that newer unpersisted messages may be missing.
Limit storage reads to five seconds and capture sender context before acquiring the active-turn lock. Bind the captured evidence to the turn that accepts the delivery, allowing an existing turn to finish while the read is pending.
Testing
Add cross-host scenarios for legacy and paginated history that verify sender evidence reaches only Guardian and excludes rolled-back permissions. Add a gated storage-read test that verifies turn completion remains unblocked and evidence is bound to the newly accepted turn.