Skip to content

Load persisted sender context for Guardian reviews - #51734

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/fe896f4e82fe3e32017fe4884846f3fa90a87949
Oct 7, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/fe896f4e82fe3e32017fe4884846f3fa90a87949

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Load persisted sender context for Guardian reviews

Why

Guardian cannot capture sender instructions from another host when the sender thread is absent from the receiver's local runtime.

What changed

Fall back to the authenticated thread store to reconstruct sender history without resuming the sender. Respect compaction and rollback, and label persisted evidence to indicate that newer unpersisted messages may be missing.

Limit storage reads to five seconds and capture sender context before acquiring the active-turn lock. Bind the captured evidence to the turn that accepts the delivery, allowing an existing turn to finish while the read is pending.

Testing

Add cross-host scenarios for legacy and paginated history that verify sender evidence reaches only Guardian and excludes rolled-back permissions. Add a gated storage-read test that verifies turn completion remains unblocked and evidence is bound to the newly accepted turn.

## Why

Guardian cannot capture sender instructions from another host when the sender thread is absent from the receiver's local runtime.

## What changed

Fall back to the authenticated thread store to reconstruct sender history without resuming the sender. Respect compaction and rollback, and label persisted evidence to indicate that newer unpersisted messages may be missing.

Limit storage reads to five seconds and capture sender context before acquiring the active-turn lock. Bind the captured evidence to the turn that accepts the delivery, allowing an existing turn to finish while the read is pending.

## Testing

Add cross-host scenarios for legacy and paginated history that verify sender evidence reaches only Guardian and excludes rolled-back permissions. Add a gated storage-read test that verifies turn completion remains unblocked and evidence is bound to the newly accepted turn.

GitOrigin-RevId: fe896f4e82fe3e32017fe4884846f3fa90a87949
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/fe896f4e82fe3e32017fe4884846f3fa90a87949 branch from 3e8fa1e to 2dae757 Compare October 7, 2026 15:47
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-07T15:47:35.465123Z 3e8fa1e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit 2dae757 into main Oct 7, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/fe896f4e82fe3e32017fe4884846f3fa90a87949 branch October 7, 2026 15:47
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 7, 2026
@ashjo42
ashjo42 deployed to issue-triage October 7, 2026 15:50 — with Image GitHub Actions Active
@ashjo42
ashjo42 deployed to issue-triage October 7, 2026 15:50 — with Image GitHub Actions Active
@ashjo42
ashjo42 deployed to issue-triage October 7, 2026 15:50 — with Image GitHub Actions Active
@xjir
xjir deployed to issue-triage October 7, 2026 15:55 — with Image GitHub Actions Active
@xjir
xjir deployed to issue-triage October 7, 2026 15:55 — with Image GitHub Actions Active
@xjir
xjir deployed to issue-triage October 7, 2026 15:55 — with Image GitHub Actions Active
@th3nolo
th3nolo deployed to issue-triage October 7, 2026 15:57 — with Image GitHub Actions Active
@th3nolo
th3nolo deployed to issue-triage October 7, 2026 15:57 — with Image GitHub Actions Active
@th3nolo
th3nolo deployed to issue-triage October 7, 2026 15:57 — with Image GitHub Actions Active
@COOLak
COOLak deployed to issue-triage October 7, 2026 16:30 — with Image GitHub Actions Active
@COOLak
COOLak deployed to issue-triage October 7, 2026 16:30 — with Image GitHub Actions Active
@COOLak
COOLak deployed to issue-triage October 7, 2026 16:30 — with Image GitHub Actions Active

This branch was successfully deployed

2 active deployments
pypi — 2dae757b Deployed Oct 7, 2026 by iceweasel-oai via publish-python-sdk #253
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.