Repository navigation
Reuse MCP handler metadata for cache comparisons - #51755
Merged
copyberry[bot] merged 1 commit intoOct 7, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## What changed Remove the duplicate tool metadata stored in `CachedMcpHandler` and compare incoming metadata directly with `McpHandler::tool_info()`. Preserve complete agent plugin namespace descriptions in the handler, applying the existing 1,000-byte limit when building tool specs and search metadata. Truncation continues to respect UTF-8 character boundaries. ## Testing Extend the agent plugin namespace description test to verify that the handler retains the full description while search output remains bounded. GitOrigin-RevId: d0a9d5f6796143315235e658e77e059657e85f13
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/d0a9d5f6796143315235e658e77e059657e85f13
branch
from
October 7, 2026 16:35
af3f71f to
4d53e6b
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/d0a9d5f6796143315235e658e77e059657e85f13
branch
October 7, 2026 16:35
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse MCP handler metadata for cache comparisons
What changed
Remove the duplicate tool metadata stored in
CachedMcpHandlerand compare incoming metadata directly withMcpHandler::tool_info().Preserve complete agent plugin namespace descriptions in the handler, applying the existing 1,000-byte limit when building tool specs and search metadata. Truncation continues to respect UTF-8 character boundaries.
Testing
Extend the agent plugin namespace description test to verify that the handler retains the full description while search output remains bounded.