Repository navigation
Prevent recursive Tokio tracing in telemetry and SQLite logs - #51775
Merged
copyberry[bot] merged 1 commit intoOct 7, 2026
Conversation
## Why Tokio runtime tracing can cause SQLite log writes to enqueue more writes and exporter activity to generate further OTLP exports. ## What changed - Exclude `tokio` and `runtime` spans from OTLP export alongside `h2` spans. - Limit `tokio::` and `runtime::` targets to `INFO` in the default log filter, and reject their `TRACE` events directly in the SQLite sink even without an outer filter. - Box and pin the session-loop future before spawning it. - Reorder tracing and Tokio test attributes, restrict the skills concurrency test's subscriber to the catalog-refresh span, and use the default log filter in the SQLite formatter comparison test. GitOrigin-RevId: f545013a2469088d7f9890c1f46bb93eb5446d2d
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/f545013a2469088d7f9890c1f46bb93eb5446d2d
branch
from
October 7, 2026 17:28
8f3e987 to
9dd7988
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/f545013a2469088d7f9890c1f46bb93eb5446d2d
branch
October 7, 2026 17:28
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent recursive Tokio tracing in telemetry and SQLite logs
Why
Tokio runtime tracing can cause SQLite log writes to enqueue more writes and exporter activity to generate further OTLP exports.
What changed
tokioandruntimespans from OTLP export alongsideh2spans.tokio::andruntime::targets toINFOin the default log filter, and reject theirTRACEevents directly in the SQLite sink even without an outer filter.