Repository navigation
Preserve sandbox overrides across execution requests - #51786
Merged
copyberry[bot] merged 1 commit intoOct 7, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## What changed Move `SandboxOverride` into the shared protocol and carry the controller's selection through tool attempts, execution requests, and exec-server process and filesystem sandbox preparation. Include it as `sandboxOverride` in filesystem sandbox contexts for observation without granting broader permissions or altering sandbox commands. Default missing values to `NoOverride` and omit that value when serializing to preserve compatibility with existing requests. ## Testing Extend tests to cover override propagation, wire round-trips for all three variants, and deserialization of requests without `sandboxOverride`. GitOrigin-RevId: 2f438cf4aef1134e3149959d14aa731682168ae5
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/2f438cf4aef1134e3149959d14aa731682168ae5
branch
from
October 7, 2026 17:59
f5c8e33 to
622e9e3
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/2f438cf4aef1134e3149959d14aa731682168ae5
branch
October 7, 2026 17:59
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve sandbox overrides across execution requests
What changed
Move
SandboxOverrideinto the shared protocol and carry the controller's selection through tool attempts, execution requests, and exec-server process and filesystem sandbox preparation. Include it assandboxOverridein filesystem sandbox contexts for observation without granting broader permissions or altering sandbox commands.Default missing values to
NoOverrideand omit that value when serializing to preserve compatibility with existing requests.Testing
Extend tests to cover override propagation, wire round-trips for all three variants, and deserialization of requests without
sandboxOverride.