Repository navigation
Avoid sharing violations when repairing Windows runtime ACLs - #51822
Merged
copyberry[bot] merged 1 commit intoOct 7, 2026
Conversation
## Why Opening active EXE/DLL files with `MAXIMUM_ALLOWED` can request access that causes sharing violations during sandbox runtime ACL repair. ## What changed Restrict `MAXIMUM_ALLOWED` opens to directories that need to suppress child ACL propagation. For files, request `READ_CONTROL | WRITE_DAC` only when an ACL update is needed. Preserve the non-inheriting grant behavior from #49690, including existing permissions, deny ACEs, and null DACLs. ## Testing Extend the Windows runtime repair regression test to hold `node.exe` open with `FILE_SHARE_READ` throughout repair and revalidation, while checking read/execute access and preserved denials. GitOrigin-RevId: 2e087b51adc0221d0eda061fa0a34d2e98409662
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/2e087b51adc0221d0eda061fa0a34d2e98409662
branch
from
October 7, 2026 20:47
00d22b7 to
dd12f89
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/2e087b51adc0221d0eda061fa0a34d2e98409662
branch
October 7, 2026 20:47
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid sharing violations when repairing Windows runtime ACLs
Why
Opening active EXE/DLL files with
MAXIMUM_ALLOWEDcan request access that causes sharing violations during sandbox runtime ACL repair.What changed
Restrict
MAXIMUM_ALLOWEDopens to directories that need to suppress child ACL propagation. For files, requestREAD_CONTROL | WRITE_DAConly when an ACL update is needed.Preserve the non-inheriting grant behavior from #49690, including existing permissions, deny ACEs, and null DACLs.
Testing
Extend the Windows runtime repair regression test to hold
node.exeopen withFILE_SHARE_READthroughout repair and revalidation, while checking read/execute access and preserved denials.