Repository navigation
Add a sandbox integrity runner with outcome and timing metrics - #51842
Merged
copyberry[bot] merged 1 commit intoOct 7, 2026
Conversation
## What changed Export `run_integrity_checks` from `exec-server` to check whether the effective filesystem policy permits writing containment dependencies on Linux, macOS, and Windows. Run preparation and checks on a blocking worker, limit waiting to five seconds, and keep results observational without affecting execution. Skip mismatched sandbox backends, full-disk-write policies, and `EscalatedSandboxWithRestrictions` overrides. Continue checking ordinary configured policies with root write access and deny restrictions. Record check outcomes, preparation time, and total duration with bounded metric tags that omit filesystem paths. ## Testing Add coverage for findings, clean results, missing dependencies, preparation errors, eligibility rules, and timeouts. Verify that timed-out workers emit no late results and that metrics contain no filesystem paths. GitOrigin-RevId: a234f4a2f629f9bb090da622cea352c99456cb00
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/a234f4a2f629f9bb090da622cea352c99456cb00
branch
from
October 7, 2026 21:52
7f7a0cd to
c2eb1f4
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/a234f4a2f629f9bb090da622cea352c99456cb00
branch
October 7, 2026 21:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a sandbox integrity runner with outcome and timing metrics
What changed
Export
run_integrity_checksfromexec-serverto check whether the effective filesystem policy permits writing containment dependencies on Linux, macOS, and Windows. Run preparation and checks on a blocking worker, limit waiting to five seconds, and keep results observational without affecting execution.Skip mismatched sandbox backends, full-disk-write policies, and
EscalatedSandboxWithRestrictionsoverrides. Continue checking ordinary configured policies with root write access and deny restrictions.Record check outcomes, preparation time, and total duration with bounded metric tags that omit filesystem paths.
Testing
Add coverage for findings, clean results, missing dependencies, preparation errors, eligibility rules, and timeouts. Verify that timed-out workers emit no late results and that metrics contain no filesystem paths.