Skip to content

Run sandbox integrity checks before commands and filesystem operations - #51843

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/a82399f8aeb8b08f9965e6121b4c7f460552af3f
Oct 7, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/a82399f8aeb8b08f9965e6121b4c7f460552af3f

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Run sandbox integrity checks before commands and filesystem operations

What changed

Wire existing sandbox integrity checks into local command preparation, exec-server process preparation, and sandboxed filesystem helper and file-open operations. Make execution request preparation asynchronous so callers can await the checks.

The checks remain observational: failures and timeouts do not prevent command execution.

Testing

Add regression tests that launch a real command after checker preparation fails or exceeds its timeout, verifying successful output and exit status.

#51843)

## What changed

Wire existing sandbox integrity checks into local command preparation, exec-server process preparation, and sandboxed filesystem helper and file-open operations. Make execution request preparation asynchronous so callers can await the checks.

The checks remain observational: failures and timeouts do not prevent command execution.

## Testing

Add regression tests that launch a real command after checker preparation fails or exceeds its timeout, verifying successful output and exit status.

GitOrigin-RevId: a82399f8aeb8b08f9965e6121b4c7f460552af3f
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/a82399f8aeb8b08f9965e6121b4c7f460552af3f branch from b2e3f22 to cba716c Compare October 7, 2026 21:52
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-07T21:52:56.039446Z b2e3f22 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit cba716c into main Oct 7, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/a82399f8aeb8b08f9965e6121b4c7f460552af3f branch October 7, 2026 21:53
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 7, 2026
@Achupy
Achupy deployed to issue-triage October 7, 2026 22:03 — with Image GitHub Actions Active
@Achupy
Achupy deployed to issue-triage October 7, 2026 22:03 — with Image GitHub Actions Active
@Achupy
Achupy deployed to issue-triage October 7, 2026 22:03 — with Image GitHub Actions Active
@Achupy
Achupy deployed to issue-triage October 7, 2026 22:05 — with Image GitHub Actions Active
@clidefrog
clidefrog deployed to issue-triage October 7, 2026 22:05 — with Image GitHub Actions Active
@clidefrog
clidefrog deployed to issue-triage October 7, 2026 22:05 — with Image GitHub Actions Active
@clidefrog
clidefrog deployed to issue-triage October 7, 2026 22:05 — with Image GitHub Actions Active
@clidefrog
clidefrog deployed to issue-triage October 7, 2026 22:06 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants