Skip to content

Preserve Cargo package names in Bazel Rust builds - #51847

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/274b741067af76313358f44c1bd9b2521938fa9c
Oct 7, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/274b741067af76313358f44c1bd9b2521938fa9c

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Preserve Cargo package names in Bazel Rust builds

What changed

Expose resolved Cargo package names in DEP_DATA, set CARGO_PKG_NAME for Rust compilation, and pass the package name to build scripts. Propagate rustc_env to generated binary targets so they receive the same package metadata as libraries.

Testing

Strengthen the packaged CLI smoke test to require --version to print exactly codex-cli <version>, using the workspace package version from codex-rs/Cargo.toml.

## What changed

Expose resolved Cargo package names in `DEP_DATA`, set `CARGO_PKG_NAME` for Rust compilation, and pass the package name to build scripts. Propagate `rustc_env` to generated binary targets so they receive the same package metadata as libraries.

## Testing

Strengthen the packaged CLI smoke test to require `--version` to print exactly `codex-cli <version>`, using the workspace package version from `codex-rs/Cargo.toml`.

GitOrigin-RevId: 274b741067af76313358f44c1bd9b2521938fa9c
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/274b741067af76313358f44c1bd9b2521938fa9c branch from 0a931f1 to 6ea82c5 Compare October 7, 2026 22:08
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
πŸ“ Code Review πŸ”„ Running since 2026-10-07T22:08:15.179541Z 0a931f1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with πŸ‘€ while any review is running, comments if it has suggestions, and reacts with πŸ‘ once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit 6ea82c5 into main Oct 7, 2026
1 check failed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/274b741067af76313358f44c1bd9b2521938fa9c branch October 7, 2026 22:08
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant