Repository navigation
Preserve Cargo package names in Bazel Rust builds - #51847
Merged
copyberry[bot] merged 1 commit intoOct 7, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## What changed Expose resolved Cargo package names in `DEP_DATA`, set `CARGO_PKG_NAME` for Rust compilation, and pass the package name to build scripts. Propagate `rustc_env` to generated binary targets so they receive the same package metadata as libraries. ## Testing Strengthen the packaged CLI smoke test to require `--version` to print exactly `codex-cli <version>`, using the workspace package version from `codex-rs/Cargo.toml`. GitOrigin-RevId: 274b741067af76313358f44c1bd9b2521938fa9c
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/274b741067af76313358f44c1bd9b2521938fa9c
branch
from
October 7, 2026 22:08
0a931f1 to
6ea82c5
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with π while any review is running, comments if it has suggestions, and reacts with π once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/274b741067af76313358f44c1bd9b2521938fa9c
branch
October 7, 2026 22:08
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve Cargo package names in Bazel Rust builds
What changed
Expose resolved Cargo package names in
DEP_DATA, setCARGO_PKG_NAMEfor Rust compilation, and pass the package name to build scripts. Propagaterustc_envto generated binary targets so they receive the same package metadata as libraries.Testing
Strengthen the packaged CLI smoke test to require
--versionto print exactlycodex-cli <version>, using the workspace package version fromcodex-rs/Cargo.toml.