Skip to content

Add an app-server prompt prefix compatibility test - #51857

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/1a69fb3abb6fc3df90a095e01bcf0d5de1818fac
Oct 7, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/1a69fb3abb6fc3df90a095e01bcf0d5de1818fac

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Add an app-server prompt prefix compatibility test

Why

Detect changes to the default model-visible prefix relative to a released CLI, requiring those changes to be gated behind a default-off feature key.

What changed

Add prompt_prefix_matches_release to compare instructions, tools, and input preceding the user message using the same client and inputs. Each binary uses its bundled model catalog and feature defaults. The comparison removes response item IDs and transport metadata and normalizes fixture paths and session identifiers while preserving prompt text, whitespace, tool descriptions, schemas, and array ordering.

Use the released binary supplied by CONTRACT_EXECUTOR_BIN when available; otherwise, compare two runs of the current binary to check determinism.

## Why

Detect changes to the default model-visible prefix relative to a released CLI, requiring those changes to be gated behind a default-off feature key.

## What changed

Add `prompt_prefix_matches_release` to compare instructions, tools, and input preceding the user message using the same client and inputs. Each binary uses its bundled model catalog and feature defaults. The comparison removes response item IDs and transport metadata and normalizes fixture paths and session identifiers while preserving prompt text, whitespace, tool descriptions, schemas, and array ordering.

Use the released binary supplied by `CONTRACT_EXECUTOR_BIN` when available; otherwise, compare two runs of the current binary to check determinism.

GitOrigin-RevId: 1a69fb3abb6fc3df90a095e01bcf0d5de1818fac
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/1a69fb3abb6fc3df90a095e01bcf0d5de1818fac branch from 4372b4a to b7a76bc Compare October 7, 2026 22:21
@copyberry
copyberry Bot merged commit b7a76bc into main Oct 7, 2026
1 check passed
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-07T22:21:45.961424Z 4372b4a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/1a69fb3abb6fc3df90a095e01bcf0d5de1818fac branch October 7, 2026 22:21
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 7, 2026
@kot2genn
kot2genn deployed to issue-triage October 7, 2026 22:25 — with Image GitHub Actions Active
@kot2genn
kot2genn deployed to issue-triage October 7, 2026 22:25 — with Image GitHub Actions Active
@kot2genn
kot2genn deployed to issue-triage October 7, 2026 22:25 — with Image GitHub Actions Active
@kot2genn
kot2genn deployed to issue-triage October 7, 2026 22:26 — with Image GitHub Actions Active
@cor-of-org
cor-of-org deployed to issue-triage October 7, 2026 22:27 — with Image GitHub Actions Active
@cor-of-org
cor-of-org deployed to issue-triage October 7, 2026 22:27 — with Image GitHub Actions Active
@cor-of-org
cor-of-org deployed to issue-triage October 7, 2026 22:27 — with Image GitHub Actions Active
@Kmollo
Kmollo deployed to issue-triage October 7, 2026 22:33 — with Image GitHub Actions Active
@Kmollo
Kmollo deployed to issue-triage October 7, 2026 22:33 — with Image GitHub Actions Active
@Kmollo
Kmollo deployed to issue-triage October 7, 2026 22:33 — with Image GitHub Actions Active
@MOTOKI-LLC
MOTOKI-LLC deployed to issue-triage October 7, 2026 22:35 — with Image GitHub Actions Active
@MOTOKI-LLC
MOTOKI-LLC deployed to issue-triage October 7, 2026 22:35 — with Image GitHub Actions Active
@MOTOKI-LLC
MOTOKI-LLC deployed to issue-triage October 7, 2026 22:35 — with Image GitHub Actions Active
@vfs90
vfs90 deployed to issue-triage October 7, 2026 22:37 — with Image GitHub Actions Active
@vfs90
vfs90 deployed to issue-triage October 7, 2026 22:37 — with Image GitHub Actions Active
@vfs90
vfs90 deployed to issue-triage October 7, 2026 22:37 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — b7a76bce Deployed Oct 7, 2026 by seasonal-currency via Generate label suggestions #52818
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants