Repository navigation
Use readable plugin mentions without suppressing same-name skills - #51865
Merged
copyberry[bot] merged 1 commit intoOct 7, 2026
Conversation
…1865) ## Why Generated app IDs produce opaque plugin mention labels. A selected `@foo` plugin mention also prevented a separate `$foo` skill mention from being submitted. ## What changed - Use eligible display names, such as `@Postman`, for plugins named `app-` followed by 32 lowercase hexadecimal characters, while preserving the plugin binding. Accept 1–64 ASCII letters, digits, underscores, or hyphens, excluding common environment variable names; otherwise retain the existing naming fallback. - Only `$` mention bindings suppress automatic skill selection, allowing `@foo $foo` to submit both the plugin and the skill. ## Testing Add naming tests for accepted display names and fallback cases, a composer snapshot verifying `@Postman` and its plugin binding, and a submission regression test for a plugin and skill sharing the name `foo`. GitOrigin-RevId: aa8c98f293d12e62d32d43206e076cbe1fcb2a3b
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/aa8c98f293d12e62d32d43206e076cbe1fcb2a3b
branch
from
October 7, 2026 22:46
f98a394 to
746103b
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/aa8c98f293d12e62d32d43206e076cbe1fcb2a3b
branch
October 7, 2026 22:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use readable plugin mentions without suppressing same-name skills
Why
Generated app IDs produce opaque plugin mention labels. A selected
@fooplugin mention also prevented a separate$fooskill mention from being submitted.What changed
@Postman, for plugins namedapp-followed by 32 lowercase hexadecimal characters, while preserving the plugin binding. Accept 1–64 ASCII letters, digits, underscores, or hyphens, excluding common environment variable names; otherwise retain the existing naming fallback.$mention bindings suppress automatic skill selection, allowing@foo $footo submit both the plugin and the skill.Testing
Add naming tests for accepted display names and fallback cases, a composer snapshot verifying
@Postmanand its plugin binding, and a submission regression test for a plugin and skill sharing the namefoo.