Skip to content

Preserve line breaks and links in multiline async questions - #51866

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/ccd7256dbaed91ce98374e52b17d3a1b87645574
Oct 7, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/ccd7256dbaed91ce98374e52b17d3a1b87645574

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Preserve line breaks and links in multiline async questions

Why

Rendering an entire question title as one terminal line removes line endings and misaligns hyperlink source ranges with the visible text.

What changed

Wrap and annotate each logical line of asynchronous question titles separately, preserving blank lines and handling both LF and CRLF endings while retaining complete hyperlink destinations.

Testing

Add a rendering regression test and snapshot covering multiline titles with code fences, Unicode text, and a URL. Check LF and CRLF rendering equivalence and hyperlink destinations at narrow and wide widths.

## Why

Rendering an entire question title as one terminal line removes line endings and misaligns hyperlink source ranges with the visible text.

## What changed

Wrap and annotate each logical line of asynchronous question titles separately, preserving blank lines and handling both LF and CRLF endings while retaining complete hyperlink destinations.

## Testing

Add a rendering regression test and snapshot covering multiline titles with code fences, Unicode text, and a URL. Check LF and CRLF rendering equivalence and hyperlink destinations at narrow and wide widths.

GitOrigin-RevId: ccd7256dbaed91ce98374e52b17d3a1b87645574
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/ccd7256dbaed91ce98374e52b17d3a1b87645574 branch from 830c570 to eef4719 Compare October 7, 2026 22:55
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-07T22:55:12.131140Z 830c570 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit eef4719 into main Oct 7, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/ccd7256dbaed91ce98374e52b17d3a1b87645574 branch October 7, 2026 22:55
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 7, 2026
@Joker58th
Joker58th deployed to issue-triage October 7, 2026 23:07 — with Image GitHub Actions Active
@Joker58th
Joker58th deployed to issue-triage October 7, 2026 23:07 — with Image GitHub Actions Active
@Joker58th
Joker58th deployed to issue-triage October 7, 2026 23:07 — with Image GitHub Actions Active
@Joker58th
Joker58th deployed to issue-triage October 7, 2026 23:08 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants