Skip to content

Record tool registration metrics for each sampling request - #51868

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/02b450743886e3d487d6c3bcda12eb65f6d1104b
Oct 7, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/02b450743886e3d487d6c3bcda12eb65f6d1104b

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Record tool registration metrics for each sampling request

What changed

Add the codex.tools.registered histogram to count finalized tool registrations by exposure and tool_mode, including zero counts for empty exposure categories. Record it once per sampling request before transport retries, excluding hosted tools. These counts describe the registered inventory, not model visibility or tool reachability.

Testing

Add an integration test covering a stream retry, direct and deferred namespace tools, a model-only tool, and hosted web search. Verify that registrations are recorded once, hosted tools are excluded, and metric labels contain no tool names or descriptions.

## What changed

Add the `codex.tools.registered` histogram to count finalized tool registrations by `exposure` and `tool_mode`, including zero counts for empty exposure categories. Record it once per sampling request before transport retries, excluding hosted tools. These counts describe the registered inventory, not model visibility or tool reachability.

## Testing

Add an integration test covering a stream retry, direct and deferred namespace tools, a model-only tool, and hosted web search. Verify that registrations are recorded once, hosted tools are excluded, and metric labels contain no tool names or descriptions.

GitOrigin-RevId: 02b450743886e3d487d6c3bcda12eb65f6d1104b
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/02b450743886e3d487d6c3bcda12eb65f6d1104b branch from d0bc8a1 to fbe97c7 Compare October 7, 2026 23:11
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-07T23:11:29.321935Z d0bc8a1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit fbe97c7 into main Oct 7, 2026
4 of 8 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/02b450743886e3d487d6c3bcda12eb65f6d1104b branch October 7, 2026 23:11
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 7, 2026
@hospotho
hospotho deployed to issue-triage October 7, 2026 23:15 — with Image GitHub Actions Active
@hospotho
hospotho deployed to issue-triage October 7, 2026 23:15 — with Image GitHub Actions Active
@hospotho
hospotho deployed to issue-triage October 7, 2026 23:15 — with Image GitHub Actions Active
@kendonB
kendonB deployed to issue-triage October 7, 2026 23:18 — with Image GitHub Actions Active
@kendonB
kendonB deployed to issue-triage October 7, 2026 23:18 — with Image GitHub Actions Active
@kendonB
kendonB deployed to issue-triage October 7, 2026 23:18 — with Image GitHub Actions Active
@bryantvolk
bryantvolk deployed to issue-triage October 7, 2026 23:18 — with Image GitHub Actions Active
@bryantvolk
bryantvolk deployed to issue-triage October 7, 2026 23:18 — with Image GitHub Actions Active
@bryantvolk
bryantvolk deployed to issue-triage October 7, 2026 23:18 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — fbe97c79 Deployed Oct 7, 2026 by bryantvolk via Generate label suggestions #52825
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants