Repository navigation
Honor the user input setting for asynchronous questions - #51908
Merged
copyberry[bot] merged 1 commit intoOct 8, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Disabling `experimental_request_user_input_enabled` previously left `request_user_input_async` available when the model advertised support for it. ## What changed Require the user input setting to be enabled before registering `request_user_input_async`, while preserving the root-agent restriction and support for both current and legacy model capability names. ## Testing Add parameterized tests covering enabled and disabled settings, current and legacy capability names, missing capabilities, and subagents. Also verify that `send_message_to_user_async` remains available to root agents independently of the user input setting. GitOrigin-RevId: 27156a3fe7da38d10fccb6384f28e755c39abc39
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/27156a3fe7da38d10fccb6384f28e755c39abc39
branch
from
October 8, 2026 02:07
672e7d7 to
82e7012
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/27156a3fe7da38d10fccb6384f28e755c39abc39
branch
October 8, 2026 02:07
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honor the user input setting for asynchronous questions
Why
Disabling
experimental_request_user_input_enabledpreviously leftrequest_user_input_asyncavailable when the model advertised support for it.What changed
Require the user input setting to be enabled before registering
request_user_input_async, while preserving the root-agent restriction and support for both current and legacy model capability names.Testing
Add parameterized tests covering enabled and disabled settings, current and legacy capability names, missing capabilities, and subagents. Also verify that
send_message_to_user_asyncremains available to root agents independently of the user input setting.