Skip to content

Support model-specific function description prefixes - #51930

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/f434e37cec010764fe3e09fb12c339e933b3c21c
Oct 8, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/f434e37cec010764fe3e09fb12c339e933b3c21c

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Support model-specific function description prefixes

What changed

Add functions_namespace_functions_description_prefixes to model tool messages, keyed by unqualified tool name. Prepend this guidance to descriptions in the functions namespace across direct declarations, Code Mode documentation, and tool-search results, including custom tools.

Trim prefixes, ignore empty values and unavailable functions, and enforce a combined 256-byte UTF-8 limit including separators for reachable tools. Keep overrides local to each step, preserve search ranking text, and retain runtime caches for unaffected tools.

Testing

Extend coverage for direct and indirect descriptions, clearing prefixes when switching models, namespace scoping for deferred dynamic tools, and tool-search cache reuse and reset.

## What changed

Add `functions_namespace_functions_description_prefixes` to model tool messages, keyed by unqualified tool name. Prepend this guidance to descriptions in the `functions` namespace across direct declarations, Code Mode documentation, and tool-search results, including custom tools.

Trim prefixes, ignore empty values and unavailable functions, and enforce a combined 256-byte UTF-8 limit including separators for reachable tools. Keep overrides local to each step, preserve search ranking text, and retain runtime caches for unaffected tools.

## Testing

Extend coverage for direct and indirect descriptions, clearing prefixes when switching models, namespace scoping for deferred dynamic tools, and tool-search cache reuse and reset.

GitOrigin-RevId: f434e37cec010764fe3e09fb12c339e933b3c21c
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/f434e37cec010764fe3e09fb12c339e933b3c21c branch from 3740a55 to e974aad Compare October 8, 2026 03:21
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-08T03:21:04.900957Z 3740a55 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit e974aad into main Oct 8, 2026
4 of 8 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/f434e37cec010764fe3e09fb12c339e933b3c21c branch October 8, 2026 03:21
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2026
@Jowjm
Jowjm deployed to issue-triage October 8, 2026 03:26 — with Image GitHub Actions Active
@Jowjm
Jowjm deployed to issue-triage October 8, 2026 03:26 — with Image GitHub Actions Active
@Jowjm
Jowjm deployed to issue-triage October 8, 2026 03:26 — with Image GitHub Actions Active
@matsuokajuri
matsuokajuri deployed to issue-triage October 8, 2026 03:30 — with Image GitHub Actions Active
@matsuokajuri
matsuokajuri deployed to issue-triage October 8, 2026 03:30 — with Image GitHub Actions Active
@matsuokajuri
matsuokajuri deployed to issue-triage October 8, 2026 03:30 — with Image GitHub Actions Active
@oyzhen
oyzhen deployed to issue-triage October 8, 2026 03:33 — with Image GitHub Actions Active
@oyzhen
oyzhen deployed to issue-triage October 8, 2026 03:33 — with Image GitHub Actions Active
@oyzhen
oyzhen deployed to issue-triage October 8, 2026 03:33 — with Image GitHub Actions Active
@oyzhen
oyzhen deployed to issue-triage October 8, 2026 03:34 — with Image GitHub Actions Active
@dean1012
dean1012 deployed to issue-triage October 8, 2026 03:47 — with Image GitHub Actions Active
@dean1012
dean1012 deployed to issue-triage October 8, 2026 03:47 — with Image GitHub Actions Active
@dean1012
dean1012 deployed to issue-triage October 8, 2026 03:47 — with Image GitHub Actions Active
@OshiroAka
OshiroAka deployed to issue-triage October 8, 2026 03:48 — with Image GitHub Actions Active
@OshiroAka
OshiroAka deployed to issue-triage October 8, 2026 03:48 — with Image GitHub Actions Active
@cyberxz2077
cyberxz2077 deployed to issue-triage October 8, 2026 03:57 — with Image GitHub Actions Active
@donwon
donwon deployed to issue-triage October 8, 2026 03:59 — with Image GitHub Actions Active
@donwon
donwon deployed to issue-triage October 8, 2026 03:59 — with Image GitHub Actions Active
@donwon
donwon deployed to issue-triage October 8, 2026 03:59 — with Image GitHub Actions Active
@eh92705
eh92705 deployed to issue-triage October 8, 2026 04:00 — with Image GitHub Actions Active
@eh92705
eh92705 deployed to issue-triage October 8, 2026 04:00 — with Image GitHub Actions Active
@eh92705
eh92705 deployed to issue-triage October 8, 2026 04:00 — with Image GitHub Actions Active
@eh92705
eh92705 deployed to issue-triage October 8, 2026 04:01 — with Image GitHub Actions Active
@glin93
glin93 deployed to issue-triage October 8, 2026 04:02 — with Image GitHub Actions Active
@glin93
glin93 deployed to issue-triage October 8, 2026 04:02 — with Image GitHub Actions Active
@glin93
glin93 deployed to issue-triage October 8, 2026 04:02 — with Image GitHub Actions Active
@glin93
glin93 deployed to issue-triage October 8, 2026 04:04 — with Image GitHub Actions Active
@ghuserasi
ghuserasi deployed to issue-triage October 8, 2026 04:13 — with Image GitHub Actions Active
@ghuserasi
ghuserasi deployed to issue-triage October 8, 2026 04:13 — with Image GitHub Actions Active
@ghuserasi
ghuserasi deployed to issue-triage October 8, 2026 04:13 — with Image GitHub Actions Active
@ghuserasi
ghuserasi deployed to issue-triage October 8, 2026 04:15 — with Image GitHub Actions Active
@psypeal
psypeal deployed to issue-triage October 8, 2026 04:16 — with Image GitHub Actions Active
@psypeal
psypeal deployed to issue-triage October 8, 2026 04:16 — with Image GitHub Actions Active
@psypeal
psypeal deployed to issue-triage October 8, 2026 04:16 — with Image GitHub Actions Active
@heartmobile
heartmobile deployed to issue-triage October 8, 2026 04:20 — with Image GitHub Actions Active
@heartmobile
heartmobile deployed to issue-triage October 8, 2026 04:20 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.