Skip to content

Attribute compaction analytics to the correct voice session - #51963

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/981da0ea2c38a87079b6bab33daf2c88fd95160f
Oct 8, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/981da0ea2c38a87079b6bab33daf2c88fd95160f

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Attribute compaction analytics to the correct voice session

Why

Compaction analytics lack a voice session ID. A compaction event can arrive after its voice session has closed or another session has started, so attribution needs to account for when compaction began.

What changed

Add voice_session_id to compaction events. Track realtime session starts, ID updates, and closures, retaining up to 16 recent closed session windows. Resolve the session from the compaction start timestamp, falling back to the turn's voice session ID.

Forward realtime session ID updates from the app server to analytics and update the active turn's attribution.

Testing

Add coverage for realtime session boundary facts, compaction event serialization, and delayed compaction events across consecutive voice sessions.

## Why

Compaction analytics lack a voice session ID. A compaction event can arrive after its voice session has closed or another session has started, so attribution needs to account for when compaction began.

## What changed

Add `voice_session_id` to compaction events. Track realtime session starts, ID updates, and closures, retaining up to 16 recent closed session windows. Resolve the session from the compaction start timestamp, falling back to the turn's voice session ID.

Forward realtime session ID updates from the app server to analytics and update the active turn's attribution.

## Testing

Add coverage for realtime session boundary facts, compaction event serialization, and delayed compaction events across consecutive voice sessions.

GitOrigin-RevId: 981da0ea2c38a87079b6bab33daf2c88fd95160f
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Note

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/981da0ea2c38a87079b6bab33daf2c88fd95160f branch from 7987745 to 14c8b77 Compare October 8, 2026 05:29
@copyberry
copyberry Bot merged commit 14c8b77 into main Oct 8, 2026
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/981da0ea2c38a87079b6bab33daf2c88fd95160f branch October 8, 2026 05:29
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2026
@gqacloud
gqacloud deployed to issue-triage October 8, 2026 05:58 — with Image GitHub Actions Active
@gqacloud
gqacloud deployed to issue-triage October 8, 2026 05:58 — with Image GitHub Actions Active
@gqacloud
gqacloud deployed to issue-triage October 8, 2026 05:58 — with Image GitHub Actions Active
@yuyuyudlc
yuyuyudlc deployed to issue-triage October 8, 2026 05:58 — with Image GitHub Actions Active
@yuyuyudlc
yuyuyudlc deployed to issue-triage October 8, 2026 05:58 — with Image GitHub Actions Active
@yuyuyudlc
yuyuyudlc deployed to issue-triage October 8, 2026 05:58 — with Image GitHub Actions Active
@yuyuyudlc
yuyuyudlc deployed to issue-triage October 8, 2026 05:59 — with Image GitHub Actions Active
@toppk
toppk deployed to issue-triage October 8, 2026 06:06 — with Image GitHub Actions Active
@toppk
toppk deployed to issue-triage October 8, 2026 06:06 — with Image GitHub Actions Active
@toppk
toppk deployed to issue-triage October 8, 2026 06:06 — with Image GitHub Actions Active
@toppk
toppk deployed to issue-triage October 8, 2026 06:07 — with Image GitHub Actions Active
@monaksia
monaksia deployed to issue-triage October 8, 2026 06:10 — with Image GitHub Actions Active
@monaksia
monaksia deployed to issue-triage October 8, 2026 06:10 — with Image GitHub Actions Active
@monaksia
monaksia deployed to issue-triage October 8, 2026 06:10 — with Image GitHub Actions Active
@Gnomico
Gnomico deployed to issue-triage October 8, 2026 06:10 — with Image GitHub Actions Active
@Gnomico
Gnomico deployed to issue-triage October 8, 2026 06:10 — with Image GitHub Actions Active
@Gnomico
Gnomico deployed to issue-triage October 8, 2026 06:10 — with Image GitHub Actions Active
@focaxisdev
focaxisdev deployed to issue-triage October 8, 2026 06:13 — with Image GitHub Actions Active
@focaxisdev
focaxisdev deployed to issue-triage October 8, 2026 06:13 — with Image GitHub Actions Active
@focaxisdev
focaxisdev deployed to issue-triage October 8, 2026 06:13 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 14c8b777 Deployed Oct 8, 2026 by focaxisdev via Generate label suggestions #52951
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.