Skip to content

Add regression coverage for cancelled agent reloads - #52040

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/ce6ed90d0049245370f26d8dbb35b9f1cd0b3063
Oct 8, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/ce6ed90d0049245370f26d8dbb35b9f1cd0b3063

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Add regression coverage for cancelled agent reloads

What changed

Add cancelled_v2_send_finishes_reload_registration to verify that cancelling a multi-agent V2 send during an evicted child's reload does not cancel registration. The test checks that the thread-created notification arrives and evicted-environment state is cleared.

Evict and reload the child again with only one child slot available to catch leaked residency pins or reservations, and verify that only the subsequent follow-up message is delivered.

## What changed

Add `cancelled_v2_send_finishes_reload_registration` to verify that cancelling a multi-agent V2 send during an evicted child's reload does not cancel registration. The test checks that the thread-created notification arrives and evicted-environment state is cleared.

Evict and reload the child again with only one child slot available to catch leaked residency pins or reservations, and verify that only the subsequent follow-up message is delivered.

GitOrigin-RevId: ce6ed90d0049245370f26d8dbb35b9f1cd0b3063
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Note

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/ce6ed90d0049245370f26d8dbb35b9f1cd0b3063 branch from 695453d to b12ac84 Compare October 8, 2026 09:48
@copyberry
copyberry Bot merged commit b12ac84 into main Oct 8, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/ce6ed90d0049245370f26d8dbb35b9f1cd0b3063 branch October 8, 2026 09:49
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2026
@15861503281
15861503281 deployed to issue-triage October 8, 2026 09:50 — with Image GitHub Actions Active
@15861503281
15861503281 deployed to issue-triage October 8, 2026 09:50 — with Image GitHub Actions Active
@15861503281
15861503281 deployed to issue-triage October 8, 2026 09:50 — with Image GitHub Actions Active
@APLSAM
APLSAM deployed to issue-triage October 8, 2026 09:51 — with Image GitHub Actions Active
@APLSAM
APLSAM deployed to issue-triage October 8, 2026 09:51 — with Image GitHub Actions Active
@APLSAM
APLSAM deployed to issue-triage October 8, 2026 09:51 — with Image GitHub Actions Active
@bupengwang
bupengwang deployed to issue-triage October 8, 2026 10:01 — with Image GitHub Actions Active
@bupengwang
bupengwang deployed to issue-triage October 8, 2026 10:01 — with Image GitHub Actions Active
@bupengwang
bupengwang deployed to issue-triage October 8, 2026 10:01 — with Image GitHub Actions Active
@bupengwang
bupengwang deployed to issue-triage October 8, 2026 10:02 — with Image GitHub Actions Active
@fzlong
fzlong deployed to issue-triage October 8, 2026 10:07 — with Image GitHub Actions Active
@fzlong
fzlong deployed to issue-triage October 8, 2026 10:07 — with Image GitHub Actions Active
@fzlong
fzlong deployed to issue-triage October 8, 2026 10:07 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — b12ac84b Deployed Oct 8, 2026 by fzlong via Generate label suggestions #53055
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants