Skip to content

Cover instant interruption in steered-input persistence tests - #52048

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/d39544ce6f5ad83489fd8a80b1e731a64c7a876c
Oct 8, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/d39544ce6f5ad83489fd8a80b1e731a64c7a876c

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Cover instant interruption in steered-input persistence tests

What changed

Extend steered_input_checkpoint_controls_next_request to cover user input with InstantInterrupt enabled under both background and synchronous checkpoint policies. Keep the original response gated until the follow-up request arrives to prove that interruption advances the turn while preserving checkpoint ordering.

Explicitly disable InstantInterrupt for user-input cases that wait for response completion, and enable it for the tool-output case to verify that tool outputs still wait for completion and synchronous persistence.

## What changed

Extend `steered_input_checkpoint_controls_next_request` to cover user input with `InstantInterrupt` enabled under both background and synchronous checkpoint policies. Keep the original response gated until the follow-up request arrives to prove that interruption advances the turn while preserving checkpoint ordering.

Explicitly disable `InstantInterrupt` for user-input cases that wait for response completion, and enable it for the tool-output case to verify that tool outputs still wait for completion and synchronous persistence.

GitOrigin-RevId: d39544ce6f5ad83489fd8a80b1e731a64c7a876c
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Note

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/d39544ce6f5ad83489fd8a80b1e731a64c7a876c branch from 76886a2 to 19b7bff Compare October 8, 2026 10:08
@copyberry
copyberry Bot merged commit 19b7bff into main Oct 8, 2026
17 of 24 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/d39544ce6f5ad83489fd8a80b1e731a64c7a876c branch October 8, 2026 10:08
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2026
@biosilicon
biosilicon deployed to issue-triage October 8, 2026 10:11 — with Image GitHub Actions Active
@biosilicon
biosilicon deployed to issue-triage October 8, 2026 10:11 — with Image GitHub Actions Active
@biosilicon
biosilicon deployed to issue-triage October 8, 2026 10:11 — with Image GitHub Actions Active
@VirgilMing
VirgilMing deployed to issue-triage October 8, 2026 10:11 — with Image GitHub Actions Active
@VirgilMing
VirgilMing deployed to issue-triage October 8, 2026 10:11 — with Image GitHub Actions Active
@VirgilMing
VirgilMing deployed to issue-triage October 8, 2026 10:11 — with Image GitHub Actions Active
@tomwnq-Tom
tomwnq-Tom deployed to issue-triage October 8, 2026 10:12 — with Image GitHub Actions Active
@tomwnq-Tom
tomwnq-Tom deployed to issue-triage October 8, 2026 10:12 — with Image GitHub Actions Active
@tomwnq-Tom
tomwnq-Tom deployed to issue-triage October 8, 2026 10:12 — with Image GitHub Actions Active
@biosilicon
biosilicon deployed to issue-triage October 8, 2026 10:12 — with Image GitHub Actions Active
@VirgilMing
VirgilMing deployed to issue-triage October 8, 2026 10:12 — with Image GitHub Actions Active
@Snollyg0ster
Snollyg0ster deployed to issue-triage October 8, 2026 10:13 — with Image GitHub Actions Active
@Snollyg0ster
Snollyg0ster deployed to issue-triage October 8, 2026 10:13 — with Image GitHub Actions Active
@Snollyg0ster
Snollyg0ster deployed to issue-triage October 8, 2026 10:13 — with Image GitHub Actions Active
@tomwnq-Tom
tomwnq-Tom deployed to issue-triage October 8, 2026 10:13 — with Image GitHub Actions Active
@tushunjie
tushunjie deployed to issue-triage October 8, 2026 10:27 — with Image GitHub Actions Active
@tushunjie
tushunjie deployed to issue-triage October 8, 2026 10:27 — with Image GitHub Actions Active
@tushunjie
tushunjie deployed to issue-triage October 8, 2026 10:27 — with Image GitHub Actions Active
@kimdrom
kimdrom deployed to issue-triage October 8, 2026 10:31 — with Image GitHub Actions Active
@kimdrom
kimdrom deployed to issue-triage October 8, 2026 10:31 — with Image GitHub Actions Active
@kimdrom
kimdrom deployed to issue-triage October 8, 2026 10:31 — with Image GitHub Actions Active
@eltellogato
eltellogato deployed to issue-triage October 8, 2026 10:38 — with Image GitHub Actions Active
@eltellogato
eltellogato deployed to issue-triage October 8, 2026 10:38 — with Image GitHub Actions Active
@eltellogato
eltellogato deployed to issue-triage October 8, 2026 10:38 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 19b7bffd Deployed Oct 8, 2026 by eltellogato via Identify potential duplicates (all issues) #53074
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.