Skip to content

Require assessment text in the Guardian parser - #52065

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/e4fb4bf7aca5b20f25f5b27300ce9a6f22c97939
Oct 8, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/e4fb4bf7aca5b20f25f5b27300ce9a6f22c97939

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Require assessment text in the Guardian parser

All callers already check that an assessment payload is present before parsing it. Change parse_guardian_assessment to accept &str instead of Option<&str> and remove its redundant missing-payload check.

Update the callers and existing parser tests to pass text directly.

All callers already check that an assessment payload is present before parsing it. Change `parse_guardian_assessment` to accept `&str` instead of `Option<&str>` and remove its redundant missing-payload check.

Update the callers and existing parser tests to pass text directly.

GitOrigin-RevId: e4fb4bf7aca5b20f25f5b27300ce9a6f22c97939
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Note

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/e4fb4bf7aca5b20f25f5b27300ce9a6f22c97939 branch from fcf13f3 to be2e129 Compare October 8, 2026 11:01
@copyberry
copyberry Bot merged commit be2e129 into main Oct 8, 2026
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/e4fb4bf7aca5b20f25f5b27300ce9a6f22c97939 branch October 8, 2026 11:01
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2026
@dorukardahan
dorukardahan deployed to issue-triage October 8, 2026 11:04 — with Image GitHub Actions Active
@dorukardahan
dorukardahan deployed to issue-triage October 8, 2026 11:04 — with Image GitHub Actions Active
@dorukardahan
dorukardahan deployed to issue-triage October 8, 2026 11:04 — with Image GitHub Actions Active
@RikutoHosaka
RikutoHosaka deployed to issue-triage October 8, 2026 11:04 — with Image GitHub Actions Active
@RikutoHosaka
RikutoHosaka deployed to issue-triage October 8, 2026 11:04 — with Image GitHub Actions Active
@RikutoHosaka
RikutoHosaka deployed to issue-triage October 8, 2026 11:04 — with Image GitHub Actions Active
@dorukardahan
dorukardahan deployed to issue-triage October 8, 2026 11:06 — with Image GitHub Actions Active
@kffz
kffz deployed to issue-triage October 8, 2026 11:24 — with Image GitHub Actions Active
@kffz
kffz deployed to issue-triage October 8, 2026 11:24 — with Image GitHub Actions Active
@kffz
kffz deployed to issue-triage October 8, 2026 11:24 — with Image GitHub Actions Active
@ljjay
ljjay deployed to issue-triage October 8, 2026 11:25 — with Image GitHub Actions Active
@ljjay
ljjay deployed to issue-triage October 8, 2026 11:25 — with Image GitHub Actions Active
@ljjay
ljjay deployed to issue-triage October 8, 2026 11:25 — with Image GitHub Actions Active
@ljjay
ljjay deployed to issue-triage October 8, 2026 11:26 — with Image GitHub Actions Active
@allanworks
allanworks deployed to issue-triage October 8, 2026 11:27 — with Image GitHub Actions Active
@allanworks
allanworks deployed to issue-triage October 8, 2026 11:27 — with Image GitHub Actions Active
@allanworks
allanworks deployed to issue-triage October 8, 2026 11:27 — with Image GitHub Actions Active
@lyjj0912
lyjj0912 deployed to issue-triage October 8, 2026 11:34 — with Image GitHub Actions Active
@lyjj0912
lyjj0912 deployed to issue-triage October 8, 2026 11:34 — with Image GitHub Actions Active
@lyjj0912
lyjj0912 deployed to issue-triage October 8, 2026 11:34 — with Image GitHub Actions Active
@SDV-G-Deploy
SDV-G-Deploy deployed to issue-triage October 8, 2026 11:38 — with Image GitHub Actions Active
@SDV-G-Deploy
SDV-G-Deploy deployed to issue-triage October 8, 2026 11:38 — with Image GitHub Actions Active
@SDV-G-Deploy
SDV-G-Deploy deployed to issue-triage October 8, 2026 11:38 — with Image GitHub Actions Active
@furkancak1r
furkancak1r deployed to issue-triage October 8, 2026 11:39 — with Image GitHub Actions Active
@furkancak1r
furkancak1r deployed to issue-triage October 8, 2026 11:39 — with Image GitHub Actions Active
@furkancak1r
furkancak1r deployed to issue-triage October 8, 2026 11:39 — with Image GitHub Actions Active
@SDV-G-Deploy
SDV-G-Deploy deployed to issue-triage October 8, 2026 11:40 — with Image GitHub Actions Active
@furkancak1r
furkancak1r deployed to issue-triage October 8, 2026 11:40 — with Image GitHub Actions Active
@Amun-MXY
Amun-MXY deployed to issue-triage October 8, 2026 11:47 — with Image GitHub Actions Active
@Amun-MXY
Amun-MXY deployed to issue-triage October 8, 2026 11:47 — with Image GitHub Actions Active
@Amun-MXY
Amun-MXY deployed to issue-triage October 8, 2026 11:47 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — be2e129e Deployed Oct 8, 2026 by Amun-MXY via Translate non-English issue #18402
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.