Repository navigation
Require assessment text in the Guardian parser - #52065
Merged
copyberry[bot] merged 1 commit intoOct 8, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
All callers already check that an assessment payload is present before parsing it. Change `parse_guardian_assessment` to accept `&str` instead of `Option<&str>` and remove its redundant missing-payload check. Update the callers and existing parser tests to pass text directly. GitOrigin-RevId: e4fb4bf7aca5b20f25f5b27300ce9a6f22c97939
Contributor
|
Note Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/e4fb4bf7aca5b20f25f5b27300ce9a6f22c97939
branch
from
October 8, 2026 11:01
fcf13f3 to
be2e129
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/e4fb4bf7aca5b20f25f5b27300ce9a6f22c97939
branch
October 8, 2026 11:01
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require assessment text in the Guardian parser
All callers already check that an assessment payload is present before parsing it. Change
parse_guardian_assessmentto accept&strinstead ofOption<&str>and remove its redundant missing-payload check.Update the callers and existing parser tests to pass text directly.