Repository navigation
Preserve side conversations across thread navigation - #52184
Merged
copyberry[bot] merged 1 commit intoOct 8, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Navigating to another thread discarded side conversations, preventing users from returning to them later. ## What changed - Keep side conversations and their event listeners, channels, and pending requests across thread switches and session resets. - Reopen a parent's existing side conversation with `/side` and submit any supplied question there. Resolve side toggles by the current thread's parent relationship. - Limit explicit return-and-discard behavior to the active side conversation, and shut down retained side conversations when exiting. ## Testing Extend regression tests to cover reopening a side conversation after navigating away, preserving its listener and pending approval during a reset, and restricting discard selection to the active side. GitOrigin-RevId: ff80566970414ba190ff650d5e413ef63dc65449
Contributor
|
Note Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/ff80566970414ba190ff650d5e413ef63dc65449
branch
from
October 8, 2026 17:31
280dfb5 to
5fe2152
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/ff80566970414ba190ff650d5e413ef63dc65449
branch
October 8, 2026 17:31
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve side conversations across thread navigation
Why
Navigating to another thread discarded side conversations, preventing users from returning to them later.
What changed
/sideand submit any supplied question there. Resolve side toggles by the current thread's parent relationship.Testing
Extend regression tests to cover reopening a side conversation after navigating away, preserving its listener and pending approval during a reset, and restricting discard selection to the active side.