Repository navigation
Allow plugin toggles while searching and preserve filters on refresh - #52200
Merged
copyberry[bot] merged 1 commit intoOct 8, 2026
Conversation
…52200) ## Why In `/plugins`, Space edits a nonempty search query, leaving filtered plugins without the advertised toggle shortcut. Refreshing the popup also clears the query. ## What changed - Add `Tab` to enable or disable the selected plugin while searching, and update toggle hints. - Preserve the search query and selected plugin when the popup refreshes after a toggle. - Give configured list bindings precedence over the `Tab` toggle and hide its hints when `Tab` is already bound. ## Testing Add regression tests and snapshots for filtered toggles, search and selection preservation, and custom `Tab` binding precedence and hints. GitOrigin-RevId: de98ba2bb3f9d8928ced7216dcc5e4b4fa4c4968
Contributor
|
Note Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/de98ba2bb3f9d8928ced7216dcc5e4b4fa4c4968
branch
from
October 8, 2026 18:06
ea7b777 to
c079352
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/de98ba2bb3f9d8928ced7216dcc5e4b4fa4c4968
branch
October 8, 2026 18:06
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow plugin toggles while searching and preserve filters on refresh
Why
In
/plugins, Space edits a nonempty search query, leaving filtered plugins without the advertised toggle shortcut. Refreshing the popup also clears the query.What changed
Tabto enable or disable the selected plugin while searching, and update toggle hints.Tabtoggle and hide its hints whenTabis already bound.Testing
Add regression tests and snapshots for filtered toggles, search and selection preservation, and custom
Tabbinding precedence and hints.