Repository navigation
Enforce application network policy in standalone MCP commands - #52215
Merged
copyberry[bot] merged 1 commit intoOct 8, 2026
Conversation
## Why Standalone MCP commands must honor `application.network` restrictions during OAuth discovery and login, even when the MCP server is allowed by its identity requirements. ## What changed - Apply local network policy to cloud configuration bootstrap authentication and activate the effective policy on the loaded CLI configuration. - Load `codex mcp add` through the shared cloud configuration loader and use its resolved `codex_home` when saving server configuration. - Block disallowed OAuth discovery requests before connecting while preserving the ability to save a server when discovery is unavailable. ## Testing Add isolated regression tests for blocked MCP discovery and login, discovery with network policy disabled, allowed and denied HTTPS destinations, and rejection of malformed managed network policy. Connection checks verify that denied requests never reach a TCP listener. GitOrigin-RevId: f91401b51d6e6b9472bb01838f0d0903f83d62f3
Contributor
|
Note Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/f91401b51d6e6b9472bb01838f0d0903f83d62f3
branch
from
October 8, 2026 18:22
58cbc91 to
79773e8
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/f91401b51d6e6b9472bb01838f0d0903f83d62f3
branch
October 8, 2026 18:22
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce application network policy in standalone MCP commands
Why
Standalone MCP commands must honor
application.networkrestrictions during OAuth discovery and login, even when the MCP server is allowed by its identity requirements.What changed
codex mcp addthrough the shared cloud configuration loader and use its resolvedcodex_homewhen saving server configuration.Testing
Add isolated regression tests for blocked MCP discovery and login, discovery with network policy disabled, allowed and denied HTTPS destinations, and rejection of malformed managed network policy. Connection checks verify that denied requests never reach a TCP listener.