Repository navigation
Enforce application network policy for daemon updates - #52223
Merged
copyberry[bot] merged 1 commit intoOct 8, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Daemon updates must honor application network restrictions and stop when their configuration cannot be loaded. ## What changed Activate the configured application network policy before creating the HTTP client for daemon updates and the PID update loop. Propagate configuration errors instead of falling back to a default HTTP client. ## Testing Add tests for configuration error propagation and managed network requirements, covering denied and unlisted destinations as well as an allowed destination. Retain coverage for `features.respect_system_proxy`. GitOrigin-RevId: 960485c7c57f34654402d7316cab9e0f66f24af3
Contributor
|
Note Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/960485c7c57f34654402d7316cab9e0f66f24af3
branch
from
October 8, 2026 18:53
87d106d to
d570b36
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/960485c7c57f34654402d7316cab9e0f66f24af3
branch
October 8, 2026 18:53
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce application network policy for daemon updates
Why
Daemon updates must honor application network restrictions and stop when their configuration cannot be loaded.
What changed
Activate the configured application network policy before creating the HTTP client for daemon updates and the PID update loop. Propagate configuration errors instead of falling back to a default HTTP client.
Testing
Add tests for configuration error propagation and managed network requirements, covering denied and unlisted destinations as well as an allowed destination. Retain coverage for
features.respect_system_proxy.