Skip to content

Honor API-key feature gates in TUI Daybreak selection - #52228

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/966f4789c9d685ff122da196a13da50c60a4b393
Oct 8, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/966f4789c9d685ff122da196a13da50c60a4b393

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Honor API-key feature gates in TUI Daybreak selection

Why

API-key accounts could retain a saved Daybreak preference without ApiKeyCyberAccessPrograms enabled. Eligible API-key turns also omitted the standard access program when Daybreak was off.

What changed

  • Require both CliDaybreak and ApiKeyCyberAccessPrograms for known API-key accounts, and refresh Daybreak state when either flag changes.
  • Use account eligibility consistently for normal turns, continuations, and background tasks so eligible API-key accounts can select the catalog's standard program when Daybreak is off.
  • Preserve resumed preferences while account state is unknown and update /daybreak help to reflect API-key eligibility.

Testing

Extend regression coverage for feature-flag combinations, API-key continuations, resumed preferences, and /daybreak help.

## Why

API-key accounts could retain a saved Daybreak preference without `ApiKeyCyberAccessPrograms` enabled. Eligible API-key turns also omitted the `standard` access program when Daybreak was off.

## What changed

- Require both `CliDaybreak` and `ApiKeyCyberAccessPrograms` for known API-key accounts, and refresh Daybreak state when either flag changes.
- Use account eligibility consistently for normal turns, continuations, and background tasks so eligible API-key accounts can select the catalog's `standard` program when Daybreak is off.
- Preserve resumed preferences while account state is unknown and update `/daybreak` help to reflect API-key eligibility.

## Testing

Extend regression coverage for feature-flag combinations, API-key continuations, resumed preferences, and `/daybreak` help.

GitOrigin-RevId: 966f4789c9d685ff122da196a13da50c60a4b393
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/966f4789c9d685ff122da196a13da50c60a4b393 branch from 8afa867 to 5505a80 Compare October 8, 2026 19:03
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-08T19:03:05.350166Z 8afa867 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit 5505a80 into main Oct 8, 2026
1 check failed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/966f4789c9d685ff122da196a13da50c60a4b393 branch October 8, 2026 19:03
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2026
@RFinal3
RFinal3 deployed to issue-triage October 8, 2026 19:10 — with Image GitHub Actions Active
@RFinal3
RFinal3 deployed to issue-triage October 8, 2026 19:10 — with Image GitHub Actions Active
@RFinal3
RFinal3 deployed to issue-triage October 8, 2026 19:10 — with Image GitHub Actions Active
@Txo83
Txo83 deployed to issue-triage October 8, 2026 19:13 — with Image GitHub Actions Active
@Txo83
Txo83 deployed to issue-triage October 8, 2026 19:13 — with Image GitHub Actions Active
@Txo83
Txo83 deployed to issue-triage October 8, 2026 19:13 — with Image GitHub Actions Active

This branch was successfully deployed

2 active deployments
issue-triage — 5505a80f Deployed Oct 8, 2026 by Txo83 via Translate non-English issue #18531
pypi — 5505a80f Deployed Oct 8, 2026 by iceweasel-oai via publish-python-sdk #265
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants