Repository navigation
Support request IDs in exec-server WebSocket handshakes - #52234
Merged
copyberry[bot] merged 1 commit intoOct 8, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## What changed - Add optional `websocketRequestId` to `environment/add` and send it as `X-Request-ID` on direct WebSocket upgrades, including reconnects. It requires a secure transport or a loopback destination. - Echo a supplied `X-Request-ID` in the exec-server WebSocket upgrade response. ## Testing Add coverage for `websocketRequestId` serialization and for handshake header forwarding and echoing, both with and without a request ID. GitOrigin-RevId: 235303ff7e1150405b7e1158d6024223144e0cc3
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/235303ff7e1150405b7e1158d6024223144e0cc3
branch
from
October 8, 2026 19:14
b7b0a23 to
5468511
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with π while any review is running, comments if it has suggestions, and reacts with π once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/235303ff7e1150405b7e1158d6024223144e0cc3
branch
October 8, 2026 19:14
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support request IDs in exec-server WebSocket handshakes
What changed
websocketRequestIdtoenvironment/addand send it asX-Request-IDon direct WebSocket upgrades, including reconnects. It requires a secure transport or a loopback destination.X-Request-IDin the exec-server WebSocket upgrade response.Testing
Add coverage for
websocketRequestIdserialization and for handshake header forwarding and echoing, both with and without a request ID.