Repository navigation
Recover gRPC code-mode sessions after missing-session errors - #52235
Merged
copyberry[bot] merged 1 commit intoOct 8, 2026
Conversation
## Why A host can reject a request for an unknown session while its lease streams remain open. Keeping that session binding prevents subsequent execution from recovering. ## What changed Invalidate the session when `Execute` (including its response stream), `Wait`, or `Terminate` returns `NOT_FOUND`, allowing the next execution to open a fresh session. Return the failed call's error without replaying execution. Document that these RPCs reserve `NOT_FOUND` for unknown sessions, while `CompleteToolCall` can use it for a missing invocation. ## Testing Add regression coverage for recovery with lease streams still open, no replay of failed execution, and preservation of session state after `INVALID_ARGUMENT`. Add a cancellation-race test confirming that a late tool-completion `NOT_FOUND` leaves the session open. GitOrigin-RevId: 85b38fdbd6d59268447b6aa6a85ea7c60ec869a7
Contributor
|
Note Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/85b38fdbd6d59268447b6aa6a85ea7c60ec869a7
branch
from
October 8, 2026 19:15
78a611d to
137f25f
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/85b38fdbd6d59268447b6aa6a85ea7c60ec869a7
branch
October 8, 2026 19:15
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recover gRPC code-mode sessions after missing-session errors
Why
A host can reject a request for an unknown session while its lease streams remain open. Keeping that session binding prevents subsequent execution from recovering.
What changed
Invalidate the session when
Execute(including its response stream),Wait, orTerminatereturnsNOT_FOUND, allowing the next execution to open a fresh session. Return the failed call's error without replaying execution.Document that these RPCs reserve
NOT_FOUNDfor unknown sessions, whileCompleteToolCallcan use it for a missing invocation.Testing
Add regression coverage for recovery with lease streams still open, no replay of failed execution, and preservation of session state after
INVALID_ARGUMENT. Add a cancellation-race test confirming that a late tool-completionNOT_FOUNDleaves the session open.