Repository navigation
Preserve subagent capabilities independently of forked history - #52241
Merged
copyberry[bot] merged 1 commit intoOct 8, 2026
Conversation
## Why Subagents should retain the spawning turn's selected skills and plugin choices whether `fork_turns` is `none` or `all`. Capability selection should not depend on copied conversation metadata. ## What changed - Use a shared child startup path for fresh and history-forked agents, inheriting selected capability roots from the spawning environment snapshot. - Pass the spawning turn's `disabled_plugin_ids` through both spawn handlers. When omitted, inherit the parent's current choices; explicit lists, including an empty list, override them. - Resolve the parent before startup so inherited client MCP settings apply even when only the session source identifies the parent. - Carry plugin choices into delegates with inherited isolation and preserve saved capability roots when resuming a child. ## Testing Add regression coverage for executor skill listing and reading, plugin MCP registration with both history modes, plugin overrides, capability-root precedence and isolation, and restoring saved child settings after parent settings change. GitOrigin-RevId: 2a6891a9bc6372fd2d1f30add2b5611f96b60594
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/2a6891a9bc6372fd2d1f30add2b5611f96b60594
branch
from
October 8, 2026 19:22
2e25b08 to
845345b
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/2a6891a9bc6372fd2d1f30add2b5611f96b60594
branch
October 8, 2026 19:22
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve subagent capabilities independently of forked history
Why
Subagents should retain the spawning turn's selected skills and plugin choices whether
fork_turnsisnoneorall. Capability selection should not depend on copied conversation metadata.What changed
disabled_plugin_idsthrough both spawn handlers. When omitted, inherit the parent's current choices; explicit lists, including an empty list, override them.Testing
Add regression coverage for executor skill listing and reading, plugin MCP registration with both history modes, plugin overrides, capability-root precedence and isolation, and restoring saved child settings after parent settings change.