Skip to content

Preserve large arguments in executed tool call metadata - #52268

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/8c199ccf39191d5d44eef02d28b1773654735b43
Oct 8, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/8c199ccf39191d5d44eef02d28b1773654735b43

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Preserve large arguments in executed tool call metadata

Why

Fixed argument limits truncated recorded tool calls even when their metadata fit within the available message budget.

What changed

  • Remove the 8 KiB per-call and 32 KiB per-output argument limits for direct calls and Code Mode.
  • Preserve full recorded arguments while retaining message metadata budgets, pending-call limits, and the direct metadata retention limit.
  • Rename the normalization helper to normalize_executed_tool_call_completeness; it now only clears completeness when calls or tool names were lost.

Testing

Update regression coverage for large arguments, escaped inputs, reserved-key wrappers, and argument and result metadata preservation across Code Mode waits.

## Why

Fixed argument limits truncated recorded tool calls even when their metadata fit within the available message budget.

## What changed

- Remove the 8 KiB per-call and 32 KiB per-output argument limits for direct calls and Code Mode.
- Preserve full recorded arguments while retaining message metadata budgets, pending-call limits, and the direct metadata retention limit.
- Rename the normalization helper to `normalize_executed_tool_call_completeness`; it now only clears completeness when calls or tool names were lost.

## Testing

Update regression coverage for large arguments, escaped inputs, reserved-key wrappers, and argument and result metadata preservation across Code Mode waits.

GitOrigin-RevId: 8c199ccf39191d5d44eef02d28b1773654735b43
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/8c199ccf39191d5d44eef02d28b1773654735b43 branch from 8195d7f to 515c291 Compare October 8, 2026 20:41
@copyberry
copyberry Bot merged commit 515c291 into main Oct 8, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/8c199ccf39191d5d44eef02d28b1773654735b43 branch October 8, 2026 20:41
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
πŸ“ Code Review πŸ”„ Running since 2026-10-08T20:41:03.321225Z 8195d7f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with πŸ‘€ while any review is running, comments if it has suggestions, and reacts with πŸ‘ once all reviews finish with no findings.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2026
@PAversano
PAversano deployed to issue-triage October 8, 2026 20:45 — with Image GitHub Actions Active
@PAversano
PAversano deployed to issue-triage October 8, 2026 20:45 — with Image GitHub Actions Active
@PAversano
PAversano deployed to issue-triage October 8, 2026 20:45 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage β€” 515c291d Deployed Oct 8, 2026 by PAversano via Identify potential duplicates (all issues) #53326
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants