Skip to content

Enable text selection in the fullscreen TUI footer - #52270

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/dd14d7ede52e97e507be24c4d6ac0299f7388a9b
Oct 8, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/dd14d7ede52e97e507be24c4d6ac0299f7388a9b

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Enable text selection in the fullscreen TUI footer

What changed

Allow mouse selection and plain-text copying of rendered status and footer text, honoring tui.copy_on_select and existing selection keyboard controls. Keep the selected region stable while other content updates, preserve Unicode and terminal hyperlinks, and clear selections when their region becomes invalid.

Defer warning clicks until a stationary mouse release so dragging selects text without opening the warning viewer. Preserve the composer draft and cursor while selecting footer text.

Testing

Add unit and snapshot coverage for visible-text copying, Unicode and hyperlinks, selection invalidation, keyboard ownership, and stationary clicks versus drags. Add a fullscreen integration test for warning selection and draft preservation.

## What changed

Allow mouse selection and plain-text copying of rendered status and footer text, honoring `tui.copy_on_select` and existing selection keyboard controls. Keep the selected region stable while other content updates, preserve Unicode and terminal hyperlinks, and clear selections when their region becomes invalid.

Defer warning clicks until a stationary mouse release so dragging selects text without opening the warning viewer. Preserve the composer draft and cursor while selecting footer text.

## Testing

Add unit and snapshot coverage for visible-text copying, Unicode and hyperlinks, selection invalidation, keyboard ownership, and stationary clicks versus drags. Add a fullscreen integration test for warning selection and draft preservation.

GitOrigin-RevId: dd14d7ede52e97e507be24c4d6ac0299f7388a9b
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/dd14d7ede52e97e507be24c4d6ac0299f7388a9b branch from 4e6a4c7 to 39f4277 Compare October 8, 2026 20:49
@copyberry
copyberry Bot merged commit 39f4277 into main Oct 8, 2026
1 check passed
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-08T20:49:27.570642Z 4e6a4c7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/dd14d7ede52e97e507be24c4d6ac0299f7388a9b branch October 8, 2026 20:49
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2026
@hashtag1974
hashtag1974 deployed to issue-triage October 8, 2026 20:59 — with Image GitHub Actions Active
@hashtag1974
hashtag1974 deployed to issue-triage October 8, 2026 20:59 — with Image GitHub Actions Active
@hashtag1974
hashtag1974 deployed to issue-triage October 8, 2026 20:59 — with Image GitHub Actions Active
@hashtag1974
hashtag1974 deployed to issue-triage October 8, 2026 21:00 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants