Repository navigation
Honor custom OTLP metrics exporters when analytics is disabled - #52278
Merged
copyberry[bot] merged 1 commit intoOct 8, 2026
Conversation
## Why Disabling OpenAI analytics also disabled explicitly configured OTLP metrics collectors. Users should be able to export metrics to their own collectors independently of `analytics.enabled`. ## What changed Apply the analytics preference only to the built-in `statsig` metrics exporter. Keep custom OTLP HTTP and gRPC exporters enabled regardless of that preference, and use `otel.metrics_exporter = "none"` to disable metrics export. Clarify these settings in config documentation and the schema. ## Testing Cover exporter selection across explicit and default analytics preferences. Update app-server and daemon telemetry tests to verify custom metrics export with analytics disabled, and worktree tests to disable metrics through the exporter setting. GitOrigin-RevId: 0c61f0f01e2b694db642ac7e7fd1dac9965c7d96
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/0c61f0f01e2b694db642ac7e7fd1dac9965c7d96
branch
from
October 8, 2026 21:18
d239333 to
2c3156a
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/0c61f0f01e2b694db642ac7e7fd1dac9965c7d96
branch
October 8, 2026 21:18
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honor custom OTLP metrics exporters when analytics is disabled
Why
Disabling OpenAI analytics also disabled explicitly configured OTLP metrics collectors. Users should be able to export metrics to their own collectors independently of
analytics.enabled.What changed
Apply the analytics preference only to the built-in
statsigmetrics exporter. Keep custom OTLP HTTP and gRPC exporters enabled regardless of that preference, and useotel.metrics_exporter = "none"to disable metrics export. Clarify these settings in config documentation and the schema.Testing
Cover exporter selection across explicit and default analytics preferences. Update app-server and daemon telemetry tests to verify custom metrics export with analytics disabled, and worktree tests to disable metrics through the exporter setting.