Repository navigation
Add opt-in credential masking for proxied sandboxed sessions - #52302
Merged
copyberry[bot] merged 1 commit intoOct 8, 2026
Conversation
## What changed - Add the disabled-by-default `features.credential_masking` flag to enable credential brokerage through an already enabled network proxy, retaining custom credential providers and managed configuration precedence. - Prevent project configuration from overriding credential masking and apply existing credential-broker protections to project shell settings when masking is enabled. - Keep brokerage inactive when the proxy is disabled. Warn at startup and after permission-profile changes when masking is inactive because sandboxing or the proxy is disabled, or provider environment keys conflict. ## Testing Add coverage for configuration precedence, project protections in both configuration loaders, permission-profile transitions, inactive-masking warnings, and shell snapshot masking of built-in and custom credentials. GitOrigin-RevId: 4bcb293356e8c1524bdaa4f1b95cbc1e935a5271
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/4bcb293356e8c1524bdaa4f1b95cbc1e935a5271
branch
from
October 8, 2026 22:27
1aef1db to
bd27456
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/4bcb293356e8c1524bdaa4f1b95cbc1e935a5271
branch
October 8, 2026 22:27
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add opt-in credential masking for proxied sandboxed sessions
What changed
features.credential_maskingflag to enable credential brokerage through an already enabled network proxy, retaining custom credential providers and managed configuration precedence.Testing
Add coverage for configuration precedence, project protections in both configuration loaders, permission-profile transitions, inactive-masking warnings, and shell snapshot masking of built-in and custom credentials.