Repository navigation
Persist remote-control RPC preferences in managed daemon settings - #52304
Merged
copyberry[bot] merged 1 commit intoOct 8, 2026
Conversation
…2304) ## Why Durable remote-control RPC changes need to update the managed daemon's launch settings so future launches use the saved preference. ## What changed - Save non-ephemeral `remoteControl/enable` and `remoteControl/disable` requests to `remoteControlEnabled` in `app-server-daemon/settings.json` for managed daemons. - Preserve other settings and write updates atomically. Skip persistence when `daemon.lock` is held so concurrent lifecycle operations take precedence without blocking the RPC. - Leave daemon settings untouched for ephemeral requests and unmanaged servers. ## Testing Add integration coverage for durable enable and disable, ephemeral requests, and lock contention. Extend the unmanaged-server test to verify that no daemon settings file is created. GitOrigin-RevId: 2baf261ed62f7c7ad87c9779ffb91c59e923f0f8
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/2baf261ed62f7c7ad87c9779ffb91c59e923f0f8
branch
from
October 8, 2026 22:42
fdf13e2 to
99aa053
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/2baf261ed62f7c7ad87c9779ffb91c59e923f0f8
branch
October 8, 2026 22:42
padmanabhankrishnamurthy
deployed
to
issue-triage
October 8, 2026 23:23 — with 
GitHub Actions
Active
GitHub Actions
Active
padmanabhankrishnamurthy
deployed
to
issue-triage
October 8, 2026 23:23 — with
GitHub Actions
Active
GitHub Actions
Active
padmanabhankrishnamurthy
deployed
to
issue-triage
October 8, 2026 23:23 — with
GitHub Actions
Active
GitHub Actions
Active
padmanabhankrishnamurthy
deployed
to
issue-triage
October 8, 2026 23:24 — with
GitHub Actions
Active
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist remote-control RPC preferences in managed daemon settings
Why
Durable remote-control RPC changes need to update the managed daemon's launch settings so future launches use the saved preference.
What changed
remoteControl/enableandremoteControl/disablerequests toremoteControlEnabledinapp-server-daemon/settings.jsonfor managed daemons.daemon.lockis held so concurrent lifecycle operations take precedence without blocking the RPC.Testing
Add integration coverage for durable enable and disable, ephemeral requests, and lock contention. Extend the unmanaged-server test to verify that no daemon settings file is created.