Skip to content

Clamp wrapped source ranges before remapping terminal hyperlinks - #52330

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/c83c817df8d3ea790f7d126768092ae317ff9217
Oct 9, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/c83c817df8d3ea790f7d126768092ae317ff9217

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Clamp wrapped source ranges before remapping terminal hyperlinks

Why

Wrapping can retain a cursor sentinel one byte past the end of the input. Using that range to slice source text during hyperlink remapping can panic.

What changed

Clamp wrapped range boundaries to the input length before calculating hyperlink columns and recording logical source ranges, keeping both aligned with the visible text.

Testing

Add a regression test that extends a wrapped range past the input boundary and verifies that the line, hyperlinks, and logical source are preserved.

)

## Why

Wrapping can retain a cursor sentinel one byte past the end of the input. Using that range to slice source text during hyperlink remapping can panic.

## What changed

Clamp wrapped range boundaries to the input length before calculating hyperlink columns and recording logical source ranges, keeping both aligned with the visible text.

## Testing

Add a regression test that extends a wrapped range past the input boundary and verifies that the line, hyperlinks, and logical source are preserved.

GitOrigin-RevId: c83c817df8d3ea790f7d126768092ae317ff9217
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/c83c817df8d3ea790f7d126768092ae317ff9217 branch from 43130fb to 22ebb0f Compare October 9, 2026 00:04
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T00:06:15.250818Z 43130fb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit 22ebb0f into main Oct 9, 2026
1 check failed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/c83c817df8d3ea790f7d126768092ae317ff9217 branch October 9, 2026 00:04
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 9, 2026
@Mills713
Mills713 deployed to issue-triage October 9, 2026 00:14 — with Image GitHub Actions Active
@Mills713
Mills713 deployed to issue-triage October 9, 2026 00:14 — with Image GitHub Actions Active
@Mills713
Mills713 deployed to issue-triage October 9, 2026 00:14 — with Image GitHub Actions Active
@mbrfail
mbrfail deployed to issue-triage October 9, 2026 00:19 — with Image GitHub Actions Active
@mbrfail
mbrfail deployed to issue-triage October 9, 2026 00:19 — with Image GitHub Actions Active
@mbrfail
mbrfail deployed to issue-triage October 9, 2026 00:19 — with Image GitHub Actions Active
@mbrfail
mbrfail deployed to issue-triage October 9, 2026 00:20 — with Image GitHub Actions Active
@asasseen
asasseen deployed to issue-triage October 9, 2026 00:24 — with Image GitHub Actions Active
@asasseen
asasseen deployed to issue-triage October 9, 2026 00:24 — with Image GitHub Actions Active
@asasseen
asasseen deployed to issue-triage October 9, 2026 00:24 — with Image GitHub Actions Active
@asasseen
asasseen deployed to issue-triage October 9, 2026 00:26 — with Image GitHub Actions Active
@MiloHolt998
MiloHolt998 deployed to issue-triage October 9, 2026 00:31 — with Image GitHub Actions Active
@MiloHolt998
MiloHolt998 deployed to issue-triage October 9, 2026 00:31 — with Image GitHub Actions Active
@MiloHolt998
MiloHolt998 deployed to issue-triage October 9, 2026 00:31 — with Image GitHub Actions Active
@taka-i
taka-i deployed to issue-triage October 9, 2026 00:32 — with Image GitHub Actions Active
@taka-i
taka-i deployed to issue-triage October 9, 2026 00:32 — with Image GitHub Actions Active
@taka-i
taka-i deployed to issue-triage October 9, 2026 00:32 — with Image GitHub Actions Active
@taka-i
taka-i deployed to issue-triage October 9, 2026 00:33 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 22ebb0fb Deployed Oct 9, 2026 by taka-i via Identify potential duplicates (open issues fallback) #53406
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants