Skip to content

Expose experimental durable thread read state in the app server - #52350

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/e7f6ddfbb1fc2fa95d1ef2876d7f0f7b9f99ff65
Oct 9, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/e7f6ddfbb1fc2fa95d1ef2876d7f0f7b9f99ff65

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Expose experimental durable thread read state in the app server

What changed

  • Add experimental readState to thread/read and a thread-ID-keyed readStates map to thread/list for eligible durable local user threads. Each receipt contains firstUnread and an opaque revision.
  • Publish new visible terminal results before turn/completed, after flushing the rollout. Reading snapshots leaves activity unread; replayed history does not publish new activity.
  • Clear unread positions removed by a paginated thread revert while preserving explicit thread-start marks and concurrent receipt updates.

Testing

Add an integration test covering completed-turn receipts, repeated reads without acknowledgement, matching list receipts, and revert cleanup with a changed revision.

## What changed

- Add experimental `readState` to `thread/read` and a thread-ID-keyed `readStates` map to `thread/list` for eligible durable local user threads. Each receipt contains `firstUnread` and an opaque `revision`.
- Publish new visible terminal results before `turn/completed`, after flushing the rollout. Reading snapshots leaves activity unread; replayed history does not publish new activity.
- Clear unread positions removed by a paginated thread revert while preserving explicit thread-start marks and concurrent receipt updates.

## Testing

Add an integration test covering completed-turn receipts, repeated reads without acknowledgement, matching list receipts, and revert cleanup with a changed revision.

GitOrigin-RevId: e7f6ddfbb1fc2fa95d1ef2876d7f0f7b9f99ff65
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/e7f6ddfbb1fc2fa95d1ef2876d7f0f7b9f99ff65 branch from 4543af0 to 0ada5d8 Compare October 9, 2026 01:22
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-09T01:22:43.059463Z 4543af0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit 0ada5d8 into main Oct 9, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/e7f6ddfbb1fc2fa95d1ef2876d7f0f7b9f99ff65 branch October 9, 2026 01:22
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 9, 2026
@zhaohui007
zhaohui007 deployed to issue-triage October 9, 2026 01:25 — with Image GitHub Actions Active
@zhaohui007
zhaohui007 deployed to issue-triage October 9, 2026 01:25 — with Image GitHub Actions Active
@zhaohui007
zhaohui007 deployed to issue-triage October 9, 2026 01:25 — with Image GitHub Actions Active
@ychsiao168
ychsiao168 deployed to issue-triage October 9, 2026 01:26 — with Image GitHub Actions Active
@ychsiao168
ychsiao168 deployed to issue-triage October 9, 2026 01:26 — with Image GitHub Actions Active
@ychsiao168
ychsiao168 deployed to issue-triage October 9, 2026 01:26 — with Image GitHub Actions Active
@ychsiao168
ychsiao168 deployed to issue-triage October 9, 2026 01:27 — with Image GitHub Actions Active
@tubban1
tubban1 deployed to issue-triage October 9, 2026 01:29 — with Image GitHub Actions Active
@tubban1
tubban1 deployed to issue-triage October 9, 2026 01:29 — with Image GitHub Actions Active
@tubban1
tubban1 deployed to issue-triage October 9, 2026 01:29 — with Image GitHub Actions Active
@tapperwijn89
tapperwijn89 deployed to issue-triage October 9, 2026 01:34 — with Image GitHub Actions Active
@tapperwijn89
tapperwijn89 deployed to issue-triage October 9, 2026 01:34 — with Image GitHub Actions Active
@tapperwijn89
tapperwijn89 deployed to issue-triage October 9, 2026 01:34 — with Image GitHub Actions Active
@tapperwijn89
tapperwijn89 deployed to issue-triage October 9, 2026 01:35 — with Image GitHub Actions Active
@tapperwijn89
tapperwijn89 deployed to issue-triage October 9, 2026 01:35 — with Image GitHub Actions Active
@tapperwijn89
tapperwijn89 deployed to issue-triage October 9, 2026 01:35 — with Image GitHub Actions Active
@tapperwijn89
tapperwijn89 deployed to issue-triage October 9, 2026 01:35 — with Image GitHub Actions Active
@tapperwijn89
tapperwijn89 deployed to issue-triage October 9, 2026 01:35 — with Image GitHub Actions Active
@tapperwijn89
tapperwijn89 deployed to issue-triage October 9, 2026 01:35 — with Image GitHub Actions Active
@tapperwijn89
tapperwijn89 deployed to issue-triage October 9, 2026 01:36 — with Image GitHub Actions Active
@anotb
anotb deployed to issue-triage October 9, 2026 01:43 — with Image GitHub Actions Active
@anotb
anotb deployed to issue-triage October 9, 2026 01:43 — with Image GitHub Actions Active
@anotb
anotb deployed to issue-triage October 9, 2026 01:43 — with Image GitHub Actions Active
@anotb
anotb deployed to issue-triage October 9, 2026 01:44 — with Image GitHub Actions Active
@tapperwijn89
tapperwijn89 deployed to issue-triage October 9, 2026 01:52 — with Image GitHub Actions Active
@tapperwijn89
tapperwijn89 deployed to issue-triage October 9, 2026 01:52 — with Image GitHub Actions Active
@tapperwijn89
tapperwijn89 deployed to issue-triage October 9, 2026 01:52 — with Image GitHub Actions Active
@tapperwijn89
tapperwijn89 deployed to issue-triage October 9, 2026 01:53 — with Image GitHub Actions Active
@Ccyuan233
Ccyuan233 deployed to issue-triage October 9, 2026 01:54 — with Image GitHub Actions Active
@Ccyuan233
Ccyuan233 deployed to issue-triage October 9, 2026 01:54 — with Image GitHub Actions Active
@Ccyuan233
Ccyuan233 deployed to issue-triage October 9, 2026 01:54 — with Image GitHub Actions Active
@Ccyuan233
Ccyuan233 deployed to issue-triage October 9, 2026 01:55 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants