Skip to content

Notify subscribers when thread read state changes - #52384

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/28935352a881b7a5e2e7f629173c3b2061bd7941
Oct 9, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/28935352a881b7a5e2e7f629173c3b2061bd7941

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Notify subscribers when thread read state changes

What changed

Add the experimental thread/readState/changed notification with threadId and the committed readState receipt. Send it to existing thread subscribers when terminal activity updates read state or a revert clears a removed unread position. Emit terminal read-state updates before turn/completed so completion remains the last notification for that result.

Expose the notification in generated JSON schemas, TypeScript types, and Python SDK models. Document experimental capability gating, subscription lifetime, notification opt-out, and refreshing receipts when concurrent responses disagree.

Testing

Extend the read-state integration test to assert that the notification receipt matches the receipt returned by thread/read after terminal activity.

## What changed

Add the experimental `thread/readState/changed` notification with `threadId` and the committed `readState` receipt. Send it to existing thread subscribers when terminal activity updates read state or a revert clears a removed unread position. Emit terminal read-state updates before `turn/completed` so completion remains the last notification for that result.

Expose the notification in generated JSON schemas, TypeScript types, and Python SDK models. Document experimental capability gating, subscription lifetime, notification opt-out, and refreshing receipts when concurrent responses disagree.

## Testing

Extend the read-state integration test to assert that the notification receipt matches the receipt returned by `thread/read` after terminal activity.

GitOrigin-RevId: 28935352a881b7a5e2e7f629173c3b2061bd7941
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-09T02:59:33.388963Z 7d7249b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/28935352a881b7a5e2e7f629173c3b2061bd7941 branch from 7d7249b to 82883da Compare October 9, 2026 02:59
@copyberry
copyberry Bot merged commit 82883da into main Oct 9, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/28935352a881b7a5e2e7f629173c3b2061bd7941 branch October 9, 2026 02:59
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 9, 2026
@Rexitry
Rexitry deployed to issue-triage October 9, 2026 03:01 — with Image GitHub Actions Active
@Rexitry
Rexitry deployed to issue-triage October 9, 2026 03:01 — with Image GitHub Actions Active
@Rexitry
Rexitry deployed to issue-triage October 9, 2026 03:01 — with Image GitHub Actions Active
@musizman168
musizman168 deployed to issue-triage October 9, 2026 03:03 — with Image GitHub Actions Active
@musizman168
musizman168 deployed to issue-triage October 9, 2026 03:03 — with Image GitHub Actions Active
@musizman168
musizman168 deployed to issue-triage October 9, 2026 03:03 — with Image GitHub Actions Active
@Rexitry
Rexitry deployed to issue-triage October 9, 2026 03:03 — with Image GitHub Actions Active
@musizman168
musizman168 deployed to issue-triage October 9, 2026 03:04 — with Image GitHub Actions Active
@ammpanda
ammpanda deployed to issue-triage October 9, 2026 03:07 — with Image GitHub Actions Active
@ammpanda
ammpanda deployed to issue-triage October 9, 2026 03:07 — with Image GitHub Actions Active
@ammpanda
ammpanda deployed to issue-triage October 9, 2026 03:07 — with Image GitHub Actions Active
@hrygo
hrygo deployed to issue-triage October 9, 2026 03:22 — with Image GitHub Actions Active
@hrygo
hrygo deployed to issue-triage October 9, 2026 03:22 — with Image GitHub Actions Active
@hrygo
hrygo deployed to issue-triage October 9, 2026 03:22 — with Image GitHub Actions Active
@hrygo
hrygo deployed to issue-triage October 9, 2026 03:23 — with Image GitHub Actions Active
@oyzhen
oyzhen deployed to issue-triage October 9, 2026 03:23 — with Image GitHub Actions Active
@oyzhen
oyzhen deployed to issue-triage October 9, 2026 03:23 — with Image GitHub Actions Active
@oyzhen
oyzhen deployed to issue-triage October 9, 2026 03:23 — with Image GitHub Actions Active
@Lambo-dash
Lambo-dash deployed to issue-triage October 9, 2026 03:33 — with Image GitHub Actions Active
@Lambo-dash
Lambo-dash deployed to issue-triage October 9, 2026 03:33 — with Image GitHub Actions Active
@Lambo-dash
Lambo-dash deployed to issue-triage October 9, 2026 03:33 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 82883da2 Deployed Oct 9, 2026 by Lambo-dash via Generate label suggestions #53469
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.