Repository navigation
Fix races in remote environment and session replacement tests - #52591
Merged
copyberry[bot] merged 1 commit intoOct 9, 2026
Conversation
## Why The remote environment test can steer before the wait tool call is recorded, discarding the call. The session replacement test can close the client while agents overview RPCs are still pending, leaving the proxy writing to a closed socket. ## What changed - Wait for the `wait-for-active-environment` function call event before steering the active turn. - Wait for `AgentsOverviewThreadsLoaded` before shutting down session replacement test cases that open the agents overview. GitOrigin-RevId: 886112a56ff6e1016efe30dbbd0256807bc1cc85
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/886112a56ff6e1016efe30dbbd0256807bc1cc85
branch
from
October 9, 2026 14:21
81b3129 to
9a59289
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/886112a56ff6e1016efe30dbbd0256807bc1cc85
branch
October 9, 2026 14:21
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix races in remote environment and session replacement tests
Why
The remote environment test can steer before the wait tool call is recorded, discarding the call. The session replacement test can close the client while agents overview RPCs are still pending, leaving the proxy writing to a closed socket.
What changed
wait-for-active-environmentfunction call event before steering the active turn.AgentsOverviewThreadsLoadedbefore shutting down session replacement test cases that open the agents overview.