Repository navigation
Upgrade hyper to 1.11.1 and test connection closure - #52608
Merged
copyberry[bot] merged 1 commit intoOct 9, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Requests with `Connection: close` must not reuse the connection even when the server responds with `Connection: keep-alive`. ## What changed Update `hyper` from 1.8.1 to 1.11.1 in `codex-rs/Cargo.lock` and add the corresponding Bazel lockfile metadata. ## Testing Add a regression test that sends two requests with `Connection: close` to a server that ignores the header and verifies that the second request uses a new connection. GitOrigin-RevId: 72b464c8ea3d9a1ad5d9e62f7896ea9a4f15a93c
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/72b464c8ea3d9a1ad5d9e62f7896ea9a4f15a93c
branch
from
October 9, 2026 15:13
f708251 to
64335d1
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with π while any review is running, comments if it has suggestions, and reacts with π once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/72b464c8ea3d9a1ad5d9e62f7896ea9a4f15a93c
branch
October 9, 2026 15:13
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade
hyperto 1.11.1 and test connection closureWhy
Requests with
Connection: closemust not reuse the connection even when the server responds withConnection: keep-alive.What changed
Update
hyperfrom 1.8.1 to 1.11.1 incodex-rs/Cargo.lockand add the corresponding Bazel lockfile metadata.Testing
Add a regression test that sends two requests with
Connection: closeto a server that ignores the header and verifies that the second request uses a new connection.